All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomaiyar, Richard Marian" <richard.marian.thomaiyar@linux.intel.com>
To: "Tony Lee (李文富)" <Tony.Lee@quantatw.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: Question of ipmi command "Set User Access" in phosphor-host-ipmid
Date: Thu, 28 May 2020 15:51:27 +0530	[thread overview]
Message-ID: <fe7a616c-bb9e-596a-ceea-940f00b052c4@linux.intel.com> (raw)
In-Reply-To: <420a769b740b4ec58c5f4702c5bb2fc2@quantatw.com>

Hi Tony,

Yes, that's correct. We already support  channel configuration using 
json(channel_config.json under phosphor-ipmi-config), and sync channel 
can be identified by the first LAN medium channel number - else we can 
add one more configuration as well).

I am ok if you want to go ahead and fix it, else will try to fix the 
same in couple of weeks.

Regards,

Richard

On 5/28/2020 1:39 PM, Tony Lee (李文富) wrote:
> Hi Richard,
>
> So, it need to check the request channel number before setting the dbus
> because it has to be in sync with system user privilege level.
>
> Since my LAN1 and the request channel number are both 2.
> Once we can get LAN1 channel number dynamically
> https://github.com/openbmc/phosphor-host-ipmid/blob/master/user_channel/user_mgmt.cpp#L512
>
> This issue will be solved right?
>
>> From: Thomaiyar, Richard Marian <richard.marian.thomaiyar@linux.intel.com>
>> Sent: Tuesday, May 26, 2020 12:28 AM
>> To: Tony Lee (李文富) <Tony.Lee@quantatw.com>
>> Cc: openbmc@lists.ozlabs.org
>> Subject: Re: Question of ipmi command "Set User Access" in
>> phosphor-host-ipmid
>>
>> Hi Tony,
>>
>> Only IPMI offers channel based user level privilege as of now, Redfish uses
>> single privilege across all channels. OpenBMC user management is designed to
>> have single user level privilege. IPMI is designed to bind one of the channel
>> privilege user to the user management, and rest maintain in it's own database.
>> LAN 1 is used for that sync.
>>
>> Note: Discussion started in Redfish forum to have a channel based restriction,
>> but it's not yet materialized and requires more takers.
>>
>> Regards,
>>
>> Richard
>>
>> On 5/25/2020 12:58 PM, Tony Lee (李文富) wrote:
>>> In the process of creating an user,
>>> I used the ipmi command "ipmitool priv <user id> <privilege level>
>> [<channel number>]".
>>> The "UserPrivilege" of the user I created in dbus is empty. Because my LAN
>> channel number is not 1.
>>>
>> https://github.com/openbmc/phosphor-host-ipmid/blob/master/user_chann
>> e
>>> l/user_mgmt.cpp#L878
>>>
>>> Why did it need to check the request channel number before setting the
>> dbus?
>>> I can't find the related restriction of it in "Set User Access Command" in IPMI
>> SPEC.
>>> Thanks
>>> Best Regards,
>>> Tony

  reply	other threads:[~2020-05-28 10:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25  7:28 Question of ipmi command "Set User Access" in phosphor-host-ipmid Tony Lee (李文富)
2020-05-25 16:28 ` Thomaiyar, Richard Marian
2020-05-28  8:09   ` Tony Lee (李文富)
2020-05-28 10:21     ` Thomaiyar, Richard Marian [this message]
2020-06-01 18:56   ` Joseph Reynolds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe7a616c-bb9e-596a-ceea-940f00b052c4@linux.intel.com \
    --to=richard.marian.thomaiyar@linux.intel.com \
    --cc=Tony.Lee@quantatw.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.