Re: [Linux-stm32] [PATCH] remoteproc: stm32_rproc: Propagate errors from optional IRQ lookup

[Arnaud POULIQUEN <arnaud.pouliquen@foss.st.com>]

On 8/10/26 07:19, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> platform_get_irq_optional() returns a positive IRQ number on success or
> a negative error code on failure. For an optional IRQ, -ENXIO indicates
> that no IRQ is available, while other errors should be propagated.
> 
> Instead of only checking for -EPROBE_DEFER, propagate all error codes
> returned by platform_get_irq_optional() other than -ENXIO, so that
> failures are properly reported to the caller.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

Acked-by: Arnaud Pouliquen arnaud.pouliquen@foss.st.com

Thanks!
Arnaud

> ---
>   drivers/remoteproc/stm32_rproc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 632614013dc6..9301e1dab830 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -705,7 +705,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>   	int err, irq;
>   
>   	irq = platform_get_irq_optional(pdev, 0);
> -	if (irq == -EPROBE_DEFER)
> +	if (irq < 0 && irq != -ENXIO)
>   		return irq;
>   
>   	if (irq > 0) {