From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove useless casts to intel_plane_state
Date: Thu, 12 Jan 2017 15:52:16 +0100 [thread overview]
Message-ID: <fe89f341-9da0-6c41-2994-72cfd321c670@linux.intel.com> (raw)
In-Reply-To: <20170112095811.GS31595@intel.com>
Op 12-01-17 om 10:58 schreef Ville Syrjälä:
> On Thu, Jan 12, 2017 at 10:43:45AM +0100, Maarten Lankhorst wrote:
>> The visible member used to be in intel_plane_state->visible,
>> but has been moved to drm_plane_state->visible. In the conversion
>> some casts were left in that are now useless.
>>
>> to_intel_plane_state(x)->base.visible is the same as x->visible,
>> so use the latter to clear up the code a little.
> I would generally prefer switching over to intel_foo_state all over.
>
> But patch looks sane anyway
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Applied, thanks for reviewing. :)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-12 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 9:43 [PATCH] drm/i915: Remove useless casts to intel_plane_state Maarten Lankhorst
2017-01-12 9:54 ` Chris Wilson
2017-01-12 9:58 ` Ville Syrjälä
2017-01-12 14:52 ` Maarten Lankhorst [this message]
2017-01-12 12:53 ` ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe89f341-9da0-6c41-2994-72cfd321c670@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.