From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5063FD1CA3B for ; Tue, 5 Nov 2024 06:56:28 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t8DUG-0001od-C2; Tue, 05 Nov 2024 06:56:24 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t8DUE-0001oW-Up for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Nov 2024 06:56:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U2GEdrmyjwS9ZsFz5JXViw7wH7+oBt0P/vGffGcf7Oc=; b=QOs5jHEh/xZwo9T3YWyG+Ws6Es hS28L8gVvfGgpgEphKpHUVq9d6JL0QxGTEOokOXkvpEctUZLeKtixC6Z198ujWiP4zeSg126f8Gps M7J9AeSqMaP9zqZ7XwRlQOV9NT0GobwxkYKkv2olqL0i1SxWFoFL5rC2U8IlAykWFPhg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=U2GEdrmyjwS9ZsFz5JXViw7wH7+oBt0P/vGffGcf7Oc=; b=ScqsZsoijsJuYQMIRbaytUJLxS CV8KxmPam/9rZgZE23I+Mb+bJl5lQXF08mdinYsXgv8D9SS8WQePPuMZqYWFFtZOP+JFx0HBKRyMu tWbKs2wfYHUJOJku3rLnJScpZLpMT30lSij9HAQd73IBJmOfeGwH3h1ceZJ+7lC+stLk=; Received: from nyc.source.kernel.org ([147.75.193.91]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1t8DUE-0008M4-3T for linux-f2fs-devel@lists.sourceforge.net; Tue, 05 Nov 2024 06:56:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2375AA419AE; Tue, 5 Nov 2024 06:54:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4D61C4CECF; Tue, 5 Nov 2024 06:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730789770; bh=Fo2fibcWfMKMCUazhkZYgaohA7hDQkPM3279WGFliLc=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=kM9Lk7Dhj3ZoWuqoKi1anVPXa2e0He9hAkpFvwOh69eU1ErvxLGilSSedBlKgGgIw 2CrjdyJK/24JV/atfF3CHvYOOBj5st1/rEo7bkFdXadBok1uUSLzDhTWVaHBgl8/w/ tcQR1jlT9pKlu/yKGaFguZrfmYREeWY2S9DC6q0HcXnSswh0R9hV2S91tq2HRbTBe/ 25eW2EWDtOLyhl3zmWVJ+HY76SJnLk93V/g8lS8m4xss0ZJaZ9sqoZoiiDI0csmPxD gI9Xzqx5rUEWAuM7zq5HJ3fdgb26A8A9bdCSBQXfLYRy4ltAKKRQWg+1+66qcFAX9u aydpS2I3b/bLw== Message-ID: Date: Tue, 5 Nov 2024 14:56:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Zhiguo Niu References: <1730685372-2995-1-git-send-email-zhiguo.niu@unisoc.com> <888aaf87-1363-4c1f-bd95-d119c72d7b30@kernel.org> Content-Language: en-US In-Reply-To: X-Headers-End: 1t8DUE-0008M4-3T Subject: Re: [f2fs-dev] [PATCH V2] f2fs: fix to adjust appropriate length for fiemap X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: ke.wang@unisoc.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Zhiguo Niu , jaegeuk@kernel.org, Hao_hao.Wang@unisoc.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMjAyNC8xMS81IDEyOjAyLCBaaGlndW8gTml1IHdyb3RlOgo+IENoYW8gWXUgPGNoYW9Aa2Vy bmVsLm9yZz4g5LqOMjAyNOW5tDEx5pyINeaXpeWRqOS6jCAxMToxNeWGmemBk++8mgo+Pgo+PiBP biAyMDI0LzExLzQgOTo1NiwgWmhpZ3VvIE5pdSB3cm90ZToKPj4+IElmIHVzZXIgZ2l2ZSBhIGZp bGUgc2l6ZSBhcyAibGVuZ3RoIiBwYXJhbWV0ZXIgZm9yIGZpZW1hcAo+Pj4gb3BlcmF0aW9ucywg YnV0IGlmIHRoaXMgc2l6ZSBpcyBub24tYmxvY2sgc2l6ZSBhbGlnbmVkLAo+Pj4gaXQgd2lsbCBz aG93IDIgc2VnbWVudHMgZmllbWFwIHJlc3VsdHMgZXZlbiB0aGlzIHdob2xlIGZpbGUKPj4+IGlz IGNvbnRpZ3VvdXMgb24gZGlzaywgc3VjaCBhcyB0aGUgZm9sbG93aW5nIHJlc3VsdHM6Cj4+Pgo+ Pj4gICAgLi9mMmZzX2lvIGZpZW1hcCAwIDE5MDM0IHlsb2cvYW5hbHl6ZXIucHkKPj4+IEZpZW1h cDogb2Zmc2V0ID0gMCBsZW4gPSAxOTAzNAo+Pj4gICAgICAgICAgIGxvZ2ljYWwgYWRkci4gICAg cGh5c2ljYWwgYWRkci4gICBsZW5ndGggICAgICAgICAgIGZsYWdzCj4+PiAwICAgICAgIDAwMDAw MDAwMDAwMDAwMDAgMDAwMDAwMDAyMGJhYTAwMCAwMDAwMDAwMDAwMDA0MDAwIDAwMDAxMDAwCj4+ PiAxICAgICAgIDAwMDAwMDAwMDAwMDQwMDAgMDAwMDAwMDAyMGJhZTAwMCAwMDAwMDAwMDAwMDAx MDAwIDAwMDAxMDAxCj4+Pgo+Pj4gYWZ0ZXIgdGhpcyBwYXRjaDoKPj4+IC4vZjJmc19pbyBmaWVt YXAgMCAxOTAzNCB5bG9nL2FuYWx5emVyLnB5Cj4+PiBGaWVtYXA6IG9mZnNldCA9IDAgbGVuID0g MTkwMzQKPj4+ICAgICAgIGxvZ2ljYWwgYWRkci4gICAgcGh5c2ljYWwgYWRkci4gICBsZW5ndGgg ICAgICAgICAgIGZsYWdzCj4+PiAwICAgIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAzMTVmMzAw MCAwMDAwMDAwMDAwMDA1MDAwIDAwMDAxMDAxCj4+Cj4+IEhpIFpoaWd1bywKPj4KPj4gQW55IHRl c3RjYXNlIHRvIHJlcHJvZHVjZSB0aGlzIGJ1Zz8gdy9vIHRoaXMgcGF0Y2gsIGl0IGxvb2tzIG91 dHB1dAo+PiBmcm9tIGZpZW1hcCBsb29rcyBmaW5lPwo+Pgo+PiBmMmZzX2lvIGZpZW1hcCAwIDE5 MDM0IGZpbGUKPj4gRmllbWFwOiBvZmZzZXQgPSAwIGxlbiA9IDE5MDM0Cj4+ICAgICAgICAgIGxv Z2ljYWwgYWRkci4gICAgcGh5c2ljYWwgYWRkci4gICBsZW5ndGggICAgICAgICAgIGZsYWdzCj4+ IDAgICAgICAgMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDA0NDAxMDAwIDAwMDAwMDAwMDAwMDUw MDAgMDAwMDEwMDEKPj4KPiBIaSBDaGFvLAo+IFNvcnJ5IEkgZGlkbid0IHdyaXRlIGNsZWFybHkg ZW5vdWdoIGFib3V0IHRoZSB0ZXN0IGNhc2UsIGFuZCBpIHB1dCB0aGUKPiBub3RlIGJlbG93IHRo ZSAiIlNpbmdlZC1vZmYiIHRhZy4KPiBsZXQgbWUgZGVzY3JpYmUgaXQgYWdhaW7vvIwgZjJmc19p byBmaWVtYXAgaGFzIGJlZW4gbW9kaWZpZWQgYnkgbWUgZm9yCj4gdGVzdGluZyBpbiBteSBsb2Nh bCwgYW5kICB0aGUgbGVuZ3RoIHBhcmFtZXRlcgo+IGlzIHRoZSByZWFsIGZpbGUgc2l6ZSBvZiB0 aGUgZmlsZSwgbm90IHRoZSBibG9jayBudW1lci4gYmVjYXVzZSB1c2VyCj4gYWxzbyBwYXNzIHRo ZSByZWFsIGZpbGUgc2l6ZSB0byBmaWVtYXAgaW9jdGwuCj4gc28gd2l0aCB0aGUgbmV3IGYyZnNf aW8gZmllbWFwLCBhIGNvbnRpZ3VvdXMgZmlsZSBvbiBkaXNrIG1heSBiZSBzaG93bgo+IDIgc2Vn bWVudHMgaWYgdGhlIGxlbmd0aCBpcyBub3QgYmxvY2sgc2l6ZSBhbGluZ2VkLgo+IHN1Y2ggYXM6 Cj4gCj4gdW1zOTYzMl8xaDEwOi9kYXRhICMgbHMgLWwgeWxvZy9hcC9hbmFseXplci5weQo+IC1y dy1ydy1ydy0gMSByb290IHN5c3RlbSAxOTAwNiAyMDA4LTAxLTAxIDAwOjAwIHlsb2cvYXAvYW5h bHl6ZXIucHkKPiB1bXM5NjMyXzFoMTA6L2RhdGEgIyAuL2YyZnNfaW8gZmllbWFwIDAgMTkwMDYg eWxvZy9hcC9hbmFseXplci5weQo+IEZpZW1hcDogb2Zmc2V0ID0gMCBsZW4gPSAxOTAwNgo+ICAg ICAgICAgIGxvZ2ljYWwgYWRkci4gICAgcGh5c2ljYWwgYWRkci4gICBsZW5ndGggICAgICAgICAg IGZsYWdzCj4gMCAgICAgICAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwMjBiYWEwMDAgMDAwMDAw MDAwMDAwNDAwMCAwMDAwMTAwMAo+IDEgICAgICAgMDAwMDAwMDAwMDAwNDAwMCAwMDAwMDAwMDIw YmFlMDAwIDAwMDAwMDAwMDAwMDEwMDAgMDAwMDEwMDEKPiAKPiBidXQgaWYgd2UgcGFzcyBhIGxl bmd0aCB0aGF0IGlzIGJsb2NrIHNpemUgYWxpbmdlZCwgaXQgd2lsbCBzaG93IG9uZQo+IHdob2xl IHNlZ21lbnQgaW4gZmllbWFwIGxvZy4KPiB1bXM5NjMyXzFoMTA6L2RhdGEgIyAuL2YyZnNfaW8g ZmllbWFwIDAgMjA0ODAgeWxvZy9hcC9hbmFseXplci5weQo+IEZpZW1hcDogb2Zmc2V0ID0gMCBs ZW4gPSAyMDQ4MAo+ICAgICAgICAgIGxvZ2ljYWwgYWRkci4gICAgcGh5c2ljYWwgYWRkci4gICBs ZW5ndGggICAgICAgICAgIGZsYWdzCj4gMCAgICAgICAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAw MjBiYWEwMDAgMDAwMDAwMDAwMDAwNTAwMCAwMDAwMTAwMQo+IFRoYW5rcy4KCk9oLCBJIGNhbiBy ZXByb2R1Y2UgaXQgdy8geGZzX2lvLCB0aGFua3MgZm9yIHlvdXIgZXhwbGFuYXRpb24uCgp4ZnNf aW8gZmlsZSAtYyAiZmllbWFwIC12IDAgMTkwMDYiCmZpbGU6CiAgRVhUOiBGSUxFLU9GRlNFVCAg ICAgIEJMT0NLLVJBTkdFICAgICAgVE9UQUwgRkxBR1MKICAgIDA6IFswLi4zMV06ICAgICAgICAg MTM5MjcyLi4xMzkzMDMgICAgICAzMiAweDEwMDAKICAgIDE6IFszMi4uMzldOiAgICAgICAgMTM5 MzA0Li4xMzkzMTEgICAgICAgOCAweDEwMDEKeGZzX2lvIGZpbGUgLWMgImZpZW1hcCAtdiAwIDIw NDgwIgpmaWxlOgogIEVYVDogRklMRS1PRkZTRVQgICAgICBCTE9DSy1SQU5HRSAgICAgIFRPVEFM IEZMQUdTCiAgICAwOiBbMC4uMzldOiAgICAgICAgIDEzOTI3Mi4uMTM5MzExICAgICAgNDAgMHgx MDAxCgpUaGFua3MsCgo+PiBUaGFua3MsCj4+Cj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogWmhpZ3Vv IE5pdSA8emhpZ3VvLm5pdUB1bmlzb2MuY29tPgo+Pj4gLS0tCj4+PiBWMjogY29ycmVjdCBjb21t aXQgbXNnIGFjY29yZGluZyB0byBDaGFvJ3MgcXVlc3Rpb25zCj4+PiBmMmZzX2lvIGhhcyBiZWVu IG1vZGlmaWVkIGZvciB0ZXN0aW5nLCB0aGUgbGVuZ3RoIGZvciBmaWVtYXAgaXMKPj4+IHJlYWwg ZmlsZSBzaXplLCBub3QgYmxvY2sgbnVtYmVyCj4+PiAtLS0KPj4+ICAgIGZzL2YyZnMvZGF0YS5j IHwgNCArKy0tCj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9mcy9mMmZzL2RhdGEuYyBiL2ZzL2YyZnMvZGF0 YS5jCj4+PiBpbmRleCAzMDZiODZiMC4uOWZjMjI5ZCAxMDA2NDQKPj4+IC0tLSBhL2ZzL2YyZnMv ZGF0YS5jCj4+PiArKysgYi9mcy9mMmZzL2RhdGEuYwo+Pj4gQEAgLTE5NjYsOCArMTk2Niw4IEBA IGludCBmMmZzX2ZpZW1hcChzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3QgZmllbWFwX2V4dGVu dF9pbmZvICpmaWVpbmZvLAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsKPj4+ ICAgICAgICB9Cj4+Pgo+Pj4gLSAgICAgaWYgKGJ5dGVzX3RvX2Jsa3MoaW5vZGUsIGxlbikgPT0g MCkKPj4+IC0gICAgICAgICAgICAgbGVuID0gYmxrc190b19ieXRlcyhpbm9kZSwgMSk7Cj4+PiAr ICAgICBpZiAobGVuICYgKGJsa3NfdG9fYnl0ZXMoaW5vZGUsIDEpIC0gMSkpCj4+PiArICAgICAg ICAgICAgIGxlbiA9IHJvdW5kX3VwKGxlbiwgYmxrc190b19ieXRlcyhpbm9kZSwgMSkpOwo+Pj4K Pj4+ICAgICAgICBzdGFydF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBzdGFydCk7Cj4+PiAg ICAgICAgbGFzdF9ibGsgPSBieXRlc190b19ibGtzKGlub2RlLCBzdGFydCArIGxlbiAtIDEpOwo+ PgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1mMmZzLWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZv cmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51 eC1mMmZzLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13DED41A8E for ; Tue, 5 Nov 2024 06:56:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730789771; cv=none; b=k+bKhV0dHxtqa1za/0fDrRXfI3BQ0jXX/LAF7ESShabF0MwPwRb0fo9gBPqGGE6SIbn7w/Woy8djNHjXEoZ5Qy9uGTTl+gXtbPlB3qgdgQceZil6C7doeSFmAbj56LW2o2HLxgSKchEkQ4DcHFg/d0nxwxRPd8xU1le+BXyGLUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730789771; c=relaxed/simple; bh=Fo2fibcWfMKMCUazhkZYgaohA7hDQkPM3279WGFliLc=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=ACk7mwFn7J1NRcdU7vft6N6QbkzsddZwjn02eRe/D8SJH9UDLJaL/i0FIYHd5XCyy3PmGhVKas12ZG7EeR2adszCBSA9Us+QQViEnD8T9gcFkb04OVzLiK5SXdYfTQH8PJ+dhxTWH2Ma7kkRdVSQvzqQAH93/aaS76cSgv545L0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kM9Lk7Dh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kM9Lk7Dh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4D61C4CECF; Tue, 5 Nov 2024 06:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730789770; bh=Fo2fibcWfMKMCUazhkZYgaohA7hDQkPM3279WGFliLc=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=kM9Lk7Dhj3ZoWuqoKi1anVPXa2e0He9hAkpFvwOh69eU1ErvxLGilSSedBlKgGgIw 2CrjdyJK/24JV/atfF3CHvYOOBj5st1/rEo7bkFdXadBok1uUSLzDhTWVaHBgl8/w/ tcQR1jlT9pKlu/yKGaFguZrfmYREeWY2S9DC6q0HcXnSswh0R9hV2S91tq2HRbTBe/ 25eW2EWDtOLyhl3zmWVJ+HY76SJnLk93V/g8lS8m4xss0ZJaZ9sqoZoiiDI0csmPxD gI9Xzqx5rUEWAuM7zq5HJ3fdgb26A8A9bdCSBQXfLYRy4ltAKKRQWg+1+66qcFAX9u aydpS2I3b/bLw== Message-ID: Date: Tue, 5 Nov 2024 14:56:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Chao Yu , Zhiguo Niu , jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Hao_hao.Wang@unisoc.com Subject: Re: [PATCH V2] f2fs: fix to adjust appropriate length for fiemap To: Zhiguo Niu References: <1730685372-2995-1-git-send-email-zhiguo.niu@unisoc.com> <888aaf87-1363-4c1f-bd95-d119c72d7b30@kernel.org> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2024/11/5 12:02, Zhiguo Niu wrote: > Chao Yu 于2024年11月5日周二 11:15写道： >> >> On 2024/11/4 9:56, Zhiguo Niu wrote: >>> If user give a file size as "length" parameter for fiemap >>> operations, but if this size is non-block size aligned, >>> it will show 2 segments fiemap results even this whole file >>> is contiguous on disk, such as the following results: >>> >>> ./f2fs_io fiemap 0 19034 ylog/analyzer.py >>> Fiemap: offset = 0 len = 19034 >>> logical addr. physical addr. length flags >>> 0 0000000000000000 0000000020baa000 0000000000004000 00001000 >>> 1 0000000000004000 0000000020bae000 0000000000001000 00001001 >>> >>> after this patch: >>> ./f2fs_io fiemap 0 19034 ylog/analyzer.py >>> Fiemap: offset = 0 len = 19034 >>> logical addr. physical addr. length flags >>> 0 0000000000000000 00000000315f3000 0000000000005000 00001001 >> >> Hi Zhiguo, >> >> Any testcase to reproduce this bug? w/o this patch, it looks output >> from fiemap looks fine? >> >> f2fs_io fiemap 0 19034 file >> Fiemap: offset = 0 len = 19034 >> logical addr. physical addr. length flags >> 0 0000000000000000 0000000004401000 0000000000005000 00001001 >> > Hi Chao, > Sorry I didn't write clearly enough about the test case, and i put the > note below the ""Singed-off" tag. > let me describe it again， f2fs_io fiemap has been modified by me for > testing in my local, and the length parameter > is the real file size of the file, not the block numer. because user > also pass the real file size to fiemap ioctl. > so with the new f2fs_io fiemap, a contiguous file on disk may be shown > 2 segments if the length is not block size alinged. > such as: > > ums9632_1h10:/data # ls -l ylog/ap/analyzer.py > -rw-rw-rw- 1 root system 19006 2008-01-01 00:00 ylog/ap/analyzer.py > ums9632_1h10:/data # ./f2fs_io fiemap 0 19006 ylog/ap/analyzer.py > Fiemap: offset = 0 len = 19006 > logical addr. physical addr. length flags > 0 0000000000000000 0000000020baa000 0000000000004000 00001000 > 1 0000000000004000 0000000020bae000 0000000000001000 00001001 > > but if we pass a length that is block size alinged, it will show one > whole segment in fiemap log. > ums9632_1h10:/data # ./f2fs_io fiemap 0 20480 ylog/ap/analyzer.py > Fiemap: offset = 0 len = 20480 > logical addr. physical addr. length flags > 0 0000000000000000 0000000020baa000 0000000000005000 00001001 > Thanks. Oh, I can reproduce it w/ xfs_io, thanks for your explanation. xfs_io file -c "fiemap -v 0 19006" file: EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS 0: [0..31]: 139272..139303 32 0x1000 1: [32..39]: 139304..139311 8 0x1001 xfs_io file -c "fiemap -v 0 20480" file: EXT: FILE-OFFSET BLOCK-RANGE TOTAL FLAGS 0: [0..39]: 139272..139311 40 0x1001 Thanks, >> Thanks, >> >>> >>> Signed-off-by: Zhiguo Niu >>> --- >>> V2: correct commit msg according to Chao's questions >>> f2fs_io has been modified for testing, the length for fiemap is >>> real file size, not block number >>> --- >>> fs/f2fs/data.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >>> index 306b86b0..9fc229d 100644 >>> --- a/fs/f2fs/data.c >>> +++ b/fs/f2fs/data.c >>> @@ -1966,8 +1966,8 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, >>> goto out; >>> } >>> >>> - if (bytes_to_blks(inode, len) == 0) >>> - len = blks_to_bytes(inode, 1); >>> + if (len & (blks_to_bytes(inode, 1) - 1)) >>> + len = round_up(len, blks_to_bytes(inode, 1)); >>> >>> start_blk = bytes_to_blks(inode, start); >>> last_blk = bytes_to_blks(inode, start + len - 1); >>