From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D571C433E0 for ; Fri, 19 Feb 2021 13:16:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B94BB64DFD for ; Fri, 19 Feb 2021 13:16:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B94BB64DFD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD5dw-0005NG-HF for qemu-devel@archiver.kernel.org; Fri, 19 Feb 2021 08:16:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD5bG-0003nn-Ja for qemu-devel@nongnu.org; Fri, 19 Feb 2021 08:13:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:52896) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD5bE-0006F3-PV for qemu-devel@nongnu.org; Fri, 19 Feb 2021 08:13:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AC5CAABAE; Fri, 19 Feb 2021 13:13:34 +0000 (UTC) Subject: Re: meson, NEED_CPU_H, CONFIG_TCG and tests/ From: Claudio Fontana To: Paolo Bonzini References: Message-ID: Date: Fri, 19 Feb 2021 14:13:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Bennee , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/19/21 2:04 PM, Claudio Fontana wrote: > Hi Paolo, > > currently we have use of CONFIG_TCG in tests/, > > but is that variable available at all in there? > > I have to adapt some qemu/tests/qtest/* to work also without tcg for ARM, > > but I think I am not seeing CONFIG_TCG filtering through, and I wonder whether all the checks in there are actually "wrong". > > Looking at meson.build it would seem to me that only stuff in target/ would be able to see CONFIG_TCG, > as a result of > > foreach target : target_dirs > config_target = config_target_mak[target] > target_name = config_target['TARGET_NAME'] > arch = config_target['TARGET_BASE_ARCH'] > arch_srcs = [config_target_h[target]] > arch_deps = [] > c_args = ['-DNEED_CPU_H', > '-DCONFIG_TARGET="@0@-config-target.h"'.format(target), > '-DCONFIG_DEVICES="@0@-config-devices.h"'.format(target)] > > But how could tests see this? > > Thanks, > > Claudio > By the way, I think Alex is working around this in the TCG tests in the tests/tcg/Makefile.target: all: -include ../../../config-host.mak -include ../config-$(TARGET).mak .. In my view we need some solution for at least: tests/qtest/qmp-cmd-test.c tests/qtest/boot-serial-test.c tests/qtest/bios-tables-test.c which need to behave differently according to whether TCG is available or not (--disable-tcg): For the specific case at hand that I encountered, reopening the issue, I need to make tests/qtest/boot-serial-test.c pass different cpu options for TCG and KVM, ie "cortex-a57" for TCG, and "host" for KVM. Wdyt? Ciao, Claudio