From: Bryan O'Donoghue <bod@kernel.org>
To: Brian Daniels <briandaniels@google.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: acourbot@google.com, adelva@google.com, aesteve@redhat.com,
changyeon@google.com, daniel.almeida@collabora.com,
eperezma@redhat.com, gnurou@gmail.com, gurchetansingh@google.com,
hverkuil@xs4all.nl, jasowang@redhat.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
mst@redhat.com, nicolas.dufresne@collabora.com,
virtualization@lists.linux.dev, xuanzhuo@linux.alibaba.com
Subject: Re: [PATCH v4 1/8] media: virtio: Add protocol
Date: Fri, 26 Jun 2026 01:50:55 +0100 [thread overview]
Message-ID: <fe970394-176b-4add-be68-74f6074ba78c@kernel.org> (raw)
In-Reply-To: <20260625202412.2986772-1-briandaniels@google.com>
On 25/06/2026 21:24, Brian Daniels wrote:
> I'm not an expert here, but taking a look at those files, the vast majority of
> those reserved fields appear to be padding to ensure the struct has 64-bit
> alignment, which matches the use here in virtio-media as well.
>
> virtio_pci appears to be the only device that explicitly states the
> reserved bytes are for future extensions. Unless there's a good a reason to
> expect a future use case where more space is needed, I would prefer to not add
> more at this time.
I'm querying why just the one though ? Why not say four ?
Perhaps something you could address in your commit log.
---
bod
next prev parent reply other threads:[~2026-06-26 0:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 20:43 [PATCH v4 0/8] media: add virtio-media driver Brian Daniels
2026-06-22 20:43 ` [PATCH v4 1/8] media: virtio: Add protocol Brian Daniels
2026-06-22 21:05 ` Michael S. Tsirkin
2026-06-25 19:50 ` Brian Daniels
2026-06-23 0:57 ` Bryan O'Donoghue
2026-06-25 20:24 ` Brian Daniels
2026-06-26 0:50 ` Bryan O'Donoghue [this message]
2026-06-26 15:50 ` Brian Daniels
2026-07-12 7:28 ` Mauro Carvalho Chehab
2026-06-22 20:43 ` [PATCH v4 2/8] media: virtio: Add virtio-media driver structs and function declarations Brian Daniels
2026-06-22 21:08 ` Michael S. Tsirkin
2026-06-23 1:09 ` Bryan O'Donoghue
2026-06-25 20:25 ` Brian Daniels
2026-06-22 20:43 ` [PATCH v4 3/8] media: virtio: Add virtio-media session related structures Brian Daniels
2026-06-22 20:43 ` [PATCH v4 4/8] media: virtio: Add scatterlist_builder Brian Daniels
2026-06-22 20:43 ` [PATCH v4 5/8] media: virtio: Add virtio_media_ioctls Brian Daniels
2026-06-22 20:43 ` [PATCH v4 6/8] media: virtio: Add virtio_media_driver Brian Daniels
2026-06-22 21:21 ` Michael S. Tsirkin
2026-06-25 20:18 ` Brian Daniels
2026-07-12 6:57 ` Mauro Carvalho Chehab
2026-06-26 13:33 ` Markus Elfring
2026-06-22 20:43 ` [PATCH v4 7/8] media: virtio: Add virtio-media to the build system Brian Daniels
2026-06-22 20:43 ` [PATCH v4 8/8] media: virtio: Add MAINTAINERS entry Brian Daniels
2026-06-22 21:23 ` Michael S. Tsirkin
2026-06-25 20:20 ` Brian Daniels
2026-06-22 21:09 ` [PATCH v4 0/8] media: add virtio-media driver Michael S. Tsirkin
2026-06-25 20:21 ` Brian Daniels
2026-07-10 20:44 ` Brian Daniels
2026-07-11 9:02 ` Michael S. Tsirkin
2026-07-12 7:10 ` Mauro Carvalho Chehab
2026-07-13 7:00 ` Albert Esteve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe970394-176b-4add-be68-74f6074ba78c@kernel.org \
--to=bod@kernel.org \
--cc=acourbot@google.com \
--cc=adelva@google.com \
--cc=aesteve@redhat.com \
--cc=briandaniels@google.com \
--cc=changyeon@google.com \
--cc=daniel.almeida@collabora.com \
--cc=eperezma@redhat.com \
--cc=gnurou@gmail.com \
--cc=gurchetansingh@google.com \
--cc=hverkuil@xs4all.nl \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mst@redhat.com \
--cc=nicolas.dufresne@collabora.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.