From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure Date: Thu, 31 Oct 2019 18:41:50 +0300 Message-ID: References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Yuehaibing , thierry.reding@gmail.com, mperttunen@nvidia.com, arnd@arndb.de, seanpaul@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org 31.10.2019 16:33, Yuehaibing пишет: > On 2019/10/31 6:26, Dmitry Osipenko wrote: >> 30.10.2019 16:54, YueHaibing пишет: >>> If IOMMU_SUPPORT is not set, but IOMMU_IOVA is m and >>> COMPILE_TEST is y, building fails: >>> >>> drivers/gpu/host1x/dev.o: In function `host1x_remove': >>> dev.c:(.text+0x624): undefined reference to `put_iova_domain' >>> dev.c:(.text+0x624): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `put_iova_domain' >>> dev.c:(.text+0x62c): undefined reference to `iova_cache_put' >>> dev.c:(.text+0x62c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `iova_cache_put' >>> >>> Select IOMMU_IOVA while COMPILE_TEST is set to fix this. >>> >>> Reported-by: Hulk Robot >>> Fixes: 52499a6ad2ae ("gpu: host1x: select IOMMU_IOVA") >>> Signed-off-by: YueHaibing >>> --- >>> drivers/gpu/host1x/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig >>> index cf987a3..354232d 100644 >>> --- a/drivers/gpu/host1x/Kconfig >>> +++ b/drivers/gpu/host1x/Kconfig >>> @@ -2,7 +2,7 @@ >>> config TEGRA_HOST1X >>> tristate "NVIDIA Tegra host1x driver" >>> depends on ARCH_TEGRA || (ARM && COMPILE_TEST) >>> - select IOMMU_IOVA if IOMMU_SUPPORT >>> + select IOMMU_IOVA if (IOMMU_SUPPORT || COMPILE_TEST) >>> help >>> Driver for the NVIDIA Tegra host1x hardware. >>> >>> >> >> It should be better to unconditionally select IOMMU_IOVA here. >> >> The same could be done for drivers/staging/media/tegra-vde/ and >> drivers/gpu/host1x/, please see [1]. > > Yep, I will repost, thanks! Oh, I missed that you made a patch for host1x and not for drm. Thus drivers/gpu/drm/tegra/ also needs the same change. >> >> [1] https://lore.kernel.org/linux-iommu/20190829154902.GC19842@ulmo/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D2FCA9EC9 for ; Fri, 1 Nov 2019 08:10:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 414FA208E3 for ; Fri, 1 Nov 2019 08:10:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 414FA208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D5616F75C; Fri, 1 Nov 2019 08:09:57 +0000 (UTC) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49B5388E46 for ; Thu, 31 Oct 2019 15:41:54 +0000 (UTC) Received: by mail-lj1-x243.google.com with SMTP id g3so1022410ljl.11 for ; Thu, 31 Oct 2019 08:41:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hs9AJBC+az+ICiDdHQdwfGOKMqZZjjUvDnX+IerCWm4=; b=Pa+1fK/r/EZaDRJPeDRNQeB9JTsnEPkDSi53AgllLf5PqvOI8VhyOQjLDmOdmgQg8t jM07ezl177vecF+GO87ELfRhzWHhiUDAn26Zv1JrKu7z2H5mJNhHoVvZGyEOpRfoieLu 0wjnHCfJLLjZfI8bv861yNrR5MxCIWwR14hzS8JzI/Et4r7ZcMwogZNdG+nuC37bxEQb CsH/9FU/K9CoQGj1bQFTPBDZFoaDUzoQpuTuIOIIWyUniDFMH8Ysu92zP8TLYD971+Ab RNxtIZ1kn0pOIWQzG4URX/iS5wrsOe6l5CKI1jvJxgLIxbUcWyUAX1PS9LuSQUsNy5Rv eWgg== X-Gm-Message-State: APjAAAXOuO0ip3aVzVlzMfQ6jAPQ+y09dHwKuWUmBd1KXbtdyNqWkfoz BF+/6dl3B0u7uiYR6xvL2PM= X-Google-Smtp-Source: APXvYqw9ljJRtaYk1C+MaZKATjFuvS0ms3pUzEegvu2xIhkxddGbBZbqsQ+yNUguxpMqrqluvMffdA== X-Received: by 2002:a05:651c:390:: with SMTP id e16mr4671922ljp.196.1572536512669; Thu, 31 Oct 2019 08:41:52 -0700 (PDT) Received: from [192.168.2.145] (94-29-10-250.dynamic.spd-mgts.ru. [94.29.10.250]) by smtp.googlemail.com with ESMTPSA id v203sm2428879lfa.25.2019.10.31.08.41.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2019 08:41:51 -0700 (PDT) Subject: Re: [PATCH -next] gpu: host1x: Fix compile test failure To: Yuehaibing , thierry.reding@gmail.com, mperttunen@nvidia.com, arnd@arndb.de, seanpaul@chromium.org References: <20191030135458.27960-1-yuehaibing@huawei.com> <283304d6-bf23-8107-29b6-9f3e7dda943c@gmail.com> From: Dmitry Osipenko Message-ID: Date: Thu, 31 Oct 2019 18:41:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Fri, 01 Nov 2019 08:09:55 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hs9AJBC+az+ICiDdHQdwfGOKMqZZjjUvDnX+IerCWm4=; b=Y5NUgS7W7OiIJXi6jmIl7T1HH8NU4D7KBflaK5Sq3mwQbHHqxGRNb7XZjwqah9S5S0 MpKIHCt7H7zLw+88fN6/+vYHFIst8/xwmcLKzP4gvInLJcY+inYL8N2bYOa5iaIrNCZ0 SZjxKGQzoAdaXaWsipubXD5a9dy8NY0oJmGlECGPd/qDvi0DIpQrPhVrMUOQKZXT0tdp C48g5+zj1G4D+/w3Pf1W3Dc0CIWPOj7D5Ypftawfbc4CIhLwh4qJQN49ujycuBFPm7gZ QUlSE/fqzwY/mxde1u3HHtcjM6yGrgy3+YMvvD6w/41kb6FVjvOKowlCksfVmP91CpID W++w== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191031154150.oX0RordmSIJUKrHhNVS6wbNdQnzLSby8TB-x6iMIwVE@z> MzEuMTAuMjAxOSAxNjozMywgWXVlaGFpYmluZyDQv9C40YjQtdGCOgo+IE9uIDIwMTkvMTAvMzEg NjoyNiwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+PiAzMC4xMC4yMDE5IDE2OjU0LCBZdWVIYWli aW5nINC/0LjRiNC10YI6Cj4+PiBJZiBJT01NVV9TVVBQT1JUIGlzIG5vdCBzZXQsIGJ1dCBJT01N VV9JT1ZBIGlzIG0gYW5kCj4+PiBDT01QSUxFX1RFU1QgaXMgeSwgYnVpbGRpbmcgZmFpbHM6Cj4+ Pgo+Pj4gZHJpdmVycy9ncHUvaG9zdDF4L2Rldi5vOiBJbiBmdW5jdGlvbiBgaG9zdDF4X3JlbW92 ZSc6Cj4+PiBkZXYuYzooLnRleHQrMHg2MjQpOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBwdXRf aW92YV9kb21haW4nCj4+PiBkZXYuYzooLnRleHQrMHg2MjQpOiByZWxvY2F0aW9uIHRydW5jYXRl ZCB0byBmaXQ6IFJfQUFSQ0g2NF9DQUxMMjYgYWdhaW5zdCB1bmRlZmluZWQgc3ltYm9sIGBwdXRf aW92YV9kb21haW4nCj4+PiBkZXYuYzooLnRleHQrMHg2MmMpOiB1bmRlZmluZWQgcmVmZXJlbmNl IHRvIGBpb3ZhX2NhY2hlX3B1dCcKPj4+IGRldi5jOigudGV4dCsweDYyYyk6IHJlbG9jYXRpb24g dHJ1bmNhdGVkIHRvIGZpdDogUl9BQVJDSDY0X0NBTEwyNiBhZ2FpbnN0IHVuZGVmaW5lZCBzeW1i b2wgYGlvdmFfY2FjaGVfcHV0Jwo+Pj4KPj4+IFNlbGVjdCBJT01NVV9JT1ZBIHdoaWxlIENPTVBJ TEVfVEVTVCBpcyBzZXQgdG8gZml4IHRoaXMuCj4+Pgo+Pj4gUmVwb3J0ZWQtYnk6IEh1bGsgUm9i b3QgPGh1bGtjaUBodWF3ZWkuY29tPgo+Pj4gRml4ZXM6IDUyNDk5YTZhZDJhZSAoImdwdTogaG9z dDF4OiBzZWxlY3QgSU9NTVVfSU9WQSIpCj4+PiBTaWduZWQtb2ZmLWJ5OiBZdWVIYWliaW5nIDx5 dWVoYWliaW5nQGh1YXdlaS5jb20+Cj4+PiAtLS0KPj4+ICBkcml2ZXJzL2dwdS9ob3N0MXgvS2Nv bmZpZyB8IDIgKy0KPj4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvaG9zdDF4L0tjb25maWcgYi9k cml2ZXJzL2dwdS9ob3N0MXgvS2NvbmZpZwo+Pj4gaW5kZXggY2Y5ODdhMy4uMzU0MjMyZCAxMDA2 NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2hvc3QxeC9LY29uZmlnCj4+PiArKysgYi9kcml2ZXJz L2dwdS9ob3N0MXgvS2NvbmZpZwo+Pj4gQEAgLTIsNyArMiw3IEBACj4+PiAgY29uZmlnIFRFR1JB X0hPU1QxWAo+Pj4gIAl0cmlzdGF0ZSAiTlZJRElBIFRlZ3JhIGhvc3QxeCBkcml2ZXIiCj4+PiAg CWRlcGVuZHMgb24gQVJDSF9URUdSQSB8fCAoQVJNICYmIENPTVBJTEVfVEVTVCkKPj4+IC0Jc2Vs ZWN0IElPTU1VX0lPVkEgaWYgSU9NTVVfU1VQUE9SVAo+Pj4gKwlzZWxlY3QgSU9NTVVfSU9WQSBp ZiAoSU9NTVVfU1VQUE9SVCB8fCBDT01QSUxFX1RFU1QpCj4+PiAgCWhlbHAKPj4+ICAJICBEcml2 ZXIgZm9yIHRoZSBOVklESUEgVGVncmEgaG9zdDF4IGhhcmR3YXJlLgo+Pj4gIAo+Pj4KPj4KPj4g SXQgc2hvdWxkIGJlIGJldHRlciB0byB1bmNvbmRpdGlvbmFsbHkgc2VsZWN0IElPTU1VX0lPVkEg aGVyZS4KPj4KPj4gVGhlIHNhbWUgY291bGQgYmUgZG9uZSBmb3IgZHJpdmVycy9zdGFnaW5nL21l ZGlhL3RlZ3JhLXZkZS8gYW5kCj4+IGRyaXZlcnMvZ3B1L2hvc3QxeC8sIHBsZWFzZSBzZWUgWzFd Lgo+IAo+IFllcCwgSSB3aWxsIHJlcG9zdCwgdGhhbmtzIQoKT2gsIEkgbWlzc2VkIHRoYXQgeW91 IG1hZGUgYSBwYXRjaCBmb3IgaG9zdDF4IGFuZCBub3QgZm9yIGRybS4gVGh1cwpkcml2ZXJzL2dw dS9kcm0vdGVncmEvIGFsc28gbmVlZHMgdGhlIHNhbWUgY2hhbmdlLgoKPj4KPj4gWzFdIGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LWlvbW11LzIwMTkwODI5MTU0OTAyLkdDMTk4NDJAdWxt by8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs