From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
Woojung Huh <woojung.huh@microchip.com>,
Linus Walleij <linus.walleij@linaro.org>,
Hauke Mehrtens <hauke@hauke-m.de>, Jiri Pirko <jiri@resnulli.us>,
Ivan Vecera <ivecera@redhat.com>, Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
DENG Qingfang <dqfext@gmail.com>,
Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net-next 2/5] net: bridge: propagate extack through store_bridge_parm
Date: Sat, 13 Feb 2021 17:06:22 -0800 [thread overview]
Message-ID: <feaa13c8-4dc8-33c7-9b53-2f67ddfba88e@gmail.com> (raw)
In-Reply-To: <20210213204319.1226170-3-olteanv@gmail.com>
On 2/13/2021 12:43, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> The bridge sysfs interface stores parameters for the STP, VLAN,
> multicast etc subsystems using a predefined function prototype.
> Sometimes the underlying function being called supports a netlink
> extended ack message, and we ignore it.
>
> Let's expand the store_bridge_parm function prototype to include the
> extack, and just print it to console, but at least propagate it where
> applicable. Where not applicable, create a shim function in the
> br_sysfs_br.c file that discards the extra function argument.
>
> This patch allows us to propagate the extack argument to
> br_vlan_set_default_pvid, br_vlan_set_proto and br_vlan_filter_toggle,
> and from there, further up in br_changelink from br_netlink.c.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-02-14 1:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 20:43 [PATCH net-next 0/5] Propagate extack for switchdev VLANs from DSA Vladimir Oltean
2021-02-13 20:43 ` [PATCH net-next 1/5] net: bridge: remove __br_vlan_filter_toggle Vladimir Oltean
2021-02-14 1:04 ` Florian Fainelli
2021-02-14 10:20 ` Nikolay Aleksandrov
2021-02-13 20:43 ` [PATCH net-next 2/5] net: bridge: propagate extack through store_bridge_parm Vladimir Oltean
2021-02-14 1:06 ` Florian Fainelli [this message]
2021-02-14 10:43 ` Nikolay Aleksandrov
2021-02-13 20:43 ` [PATCH net-next 3/5] net: bridge: propagate extack through switchdev_port_attr_set Vladimir Oltean
2021-02-14 1:14 ` Florian Fainelli
2021-02-14 10:45 ` Nikolay Aleksandrov
2021-02-14 16:39 ` Vladimir Oltean
2021-02-13 20:43 ` [PATCH net-next 4/5] net: dsa: propagate extack to .port_vlan_add Vladimir Oltean
2021-02-14 1:16 ` Florian Fainelli
2021-02-13 20:43 ` [PATCH net-next 5/5] net: dsa: propagate extack to .port_vlan_filtering Vladimir Oltean
2021-02-14 1:17 ` Florian Fainelli
2021-02-15 20:40 ` [PATCH net-next 0/5] Propagate extack for switchdev VLANs from DSA patchwork-bot+netdevbpf
2021-02-15 20:49 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=feaa13c8-4dc8-33c7-9b53-2f67ddfba88e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=hauke@hauke-m.de \
--cc=idosch@idosch.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=roopa@nvidia.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.