From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] xen/spinlock: use lock address for lock debug functions
Date: Fri, 25 Feb 2022 09:47:39 +0100 [thread overview]
Message-ID: <fec22cee-d8f4-676c-7ec4-7f65f93af061@suse.com> (raw)
In-Reply-To: <7009dbf4-d814-6181-7315-a4fce21ee338@suse.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 475 bytes --]
On 24.02.22 17:12, Jan Beulich wrote:
> On 24.02.2022 11:54, Juergen Gross wrote:
>> Instead of only passing the lock_debug address to check_lock() et al
>> use the address of the spinlock.
>
> I'm uncertain about this full exposure. The next patch looks to again
> only use the new "data" subfield in these debugging helpers.
Nevertheless I don't think that this detail should be exported,
especially as check_lock() is being used for rwlocks, too.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-02-25 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 10:54 [PATCH 0/2] xen/spinlock: cleanup struct spinlock Juergen Gross
2022-02-24 10:54 ` [PATCH 1/2] xen/spinlock: use lock address for lock debug functions Juergen Gross
2022-02-24 16:12 ` Jan Beulich
2022-02-25 8:47 ` Juergen Gross [this message]
2022-02-24 10:54 ` [PATCH 2/2] xen/spinlock: merge recurse_cpu and debug.cpu fields in struct spinlock Juergen Gross
2022-02-24 16:11 ` Jan Beulich
2022-02-25 8:36 ` Juergen Gross
2022-02-25 8:55 ` Juergen Gross
2022-02-25 9:24 ` Jan Beulich
2022-02-25 9:38 ` Juergen Gross
2022-02-25 9:13 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec22cee-d8f4-676c-7ec4-7f65f93af061@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.