All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Ahern <dsahern@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/3] net: core: Unify dstats with tstats and lstats, add generic collection helper
Date: Thu, 06 Jun 2024 11:01:01 +0800	[thread overview]
Message-ID: <fec284041a4a4ccc450fdfd504aae4f24458b79c.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240605191800.2b12df8d@kernel.org>

Hi Jakub,

> > If we're not exporting the helpers, that means that drivers that
> > use
> > dstats wouldn't have a facility to customise the stats collection
> > through a ndo_get_stats64() callback though (as can be done with
> > tstats). Are you ok with that?
> > 
> > [the set of drivers that need that is currently zero, so more of a
> > hypothetical future problem...]
> 
> Right, but I think "no exports unless there is an in-tree user"
> is still a rule. A bit of a risk that someone will roll their own
> per-cpu stats pointlessly if we lack this export. But let's try
> to catch that in review..

OK, sounds good! I'll send a v3 shortly.

Cheers,


Jeremy

  reply	other threads:[~2024-06-06  3:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  9:42 [PATCH net-next v2 0/3] net: core: Unify dstats with tstats and lstats, add generic collection helper Jeremy Kerr
2024-06-05  9:42 ` [PATCH net-next v2 1/3] net: core,vrf: Change pcpu_dstat fields to u64_stats_t Jeremy Kerr
2024-06-05  9:42 ` [PATCH net-next v2 2/3] net: core: Implement dstats-type stats collections Jeremy Kerr
2024-06-05  9:42 ` [PATCH net-next v2 3/3] net: vrf: move to generic dstat helpers Jeremy Kerr
2024-06-06  2:02 ` [PATCH net-next v2 0/3] net: core: Unify dstats with tstats and lstats, add generic collection helper Jakub Kicinski
2024-06-06  2:11   ` Jeremy Kerr
2024-06-06  2:18     ` Jakub Kicinski
2024-06-06  3:01       ` Jeremy Kerr [this message]
2024-06-06  3:08         ` Jakub Kicinski
2024-06-06  3:24           ` Jeremy Kerr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fec284041a4a4ccc450fdfd504aae4f24458b79c.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.