Re: [f2fs-dev] [PATCH v7 06/11] f2fs: describe {i, d, id}node block layout dynamically

[Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>]

Kelvin,

On 9/3/26 07:52, Xinping Zhang wrote:
> Hi Chao,
> 
> The 0-day build failure on feature/subpage (lkp report; 6/11,
> include/linux/f2fs_fs.h:355: "expected specifier-qualifier-list before
> '*' token") is a nested comment in struct f2fs_inode.
> 
> The applied commit keeps the old inline comment "/* direct(2)... node
> id */" inside the new block comment, so the inner "*/" closes the comment
> early and the following lines get parsed as struct members:
> 
>     /*
>      * __le32 i_nid[DEF_NIDS_PER_INODE];  /* direct(2), indirect(2),
>      *                  double_indirect(1) node id */
>      *
>      * It is stored immediately before the node footer ...
>      */
> 
> That's a hard compile error on every arch, not just m68k-allmodconfig.
> 
> The version I posted in v7 6/11 doesn't have this; it drops the old
> inline comment. The applied commit (35efac5) looks like an earlier
> revision -- its subject is "{i, d, id}node" (with spaces) vs
> "{i,d,id}node" in v7. Could you re-apply v7's 6/11, or de-nest the
> comment, e.g.:
> 
>     /*
>      * __le32 i_nid[DEF_NIDS_PER_INODE];
>      * direct(2), indirect(2), double_indirect(1) node IDs
>      *
>      * It is stored immediately before the node footer at the end of
>      * the filesystem block. Its offset depends on the filesystem block
>      * size, so locate it dynamically with F2FS_INODE_NIDS().
>      */

Done, let me know if you have a new version, I can help to cache in my tree
for lkp build test.

Thanks,

> 
> Thanks,
> Kelvin



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel