From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Mateusz Marciniec <mateuszmar2@gmail.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Cc: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com>
Subject: RE: [OE-core] [PATCH] util-linux: Remove raw flags in EXTRA_OECONF
Date: Fri, 19 Aug 2022 14:38:28 +0000 [thread overview]
Message-ID: <fedbfff08c3f42e693fe007d4066d0cf@axis.com> (raw)
In-Reply-To: <20220819113336.3167-1-mateuszmar2@gmail.com>
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Mateusz Marciniec
> Sent: den 19 augusti 2022 13:34
> To: openembedded-core@lists.openembedded.org
> Cc: Mateusz Marciniec <mateuszmar2@gmail.com>; Tomasz Dziendzielski
> <tomasz.dziendzielski@gmail.com>
> Subject: [OE-core] [PATCH] util-linux: Remove raw flags in EXTRA_OECONF
>
> Having both enable and disable flags for raw is confusing.
> Raw should not be enabled so both flags can be removed.
>
> Signed-off-by: Mateusz Marciniec <mateuszmar2@gmail.com>
> Signed-off-by: Tomasz Dziendzielski <tomasz.dziendzielski@gmail.com>
> ---
> meta/recipes-core/util-linux/util-linux_2.38.1.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux_2.38.1.bb
> b/meta/recipes-core/util-linux/util-linux_2.38.1.bb
> index 8a7b47a0c6..a93ae83cd6 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.38.1.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.38.1.bb
> @@ -69,12 +69,12 @@ EXTRA_OECONF = "\
> --enable-libuuid --enable-libblkid \
> \
> --enable-fsck --enable-kill --enable-last --enable-mesg \
> - --enable-mount --enable-partx --enable-raw --enable-rfkill \
> + --enable-mount --enable-partx --enable-rfkill \
> --enable-unshare --enable-write \
> \
> --disable-bfs --disable-login \
> --disable-makeinstall-chown --disable-minix --disable-newgrp \
> - --disable-use-tty-group --disable-vipw --disable-raw \
> + --disable-use-tty-group --disable-vipw \
A quick look in configure.ac for util-linux indicates that it will
start to look for linux/raw.h and enable raw support if it exists
if you remove the --disable-raw option. So you should leave the
--disable-raw option to maintain the current deterministic behavior.
> \
> --without-udev \
> \
> --
> 2.37.1
//Peter
next prev parent reply other threads:[~2022-08-19 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 11:33 [PATCH] util-linux: Remove raw flags in EXTRA_OECONF Mateusz Marciniec
2022-08-19 14:38 ` Peter Kjellerstedt [this message]
2022-08-23 9:38 ` [OE-core] " Mateusz Marciniec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fedbfff08c3f42e693fe007d4066d0cf@axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=mateuszmar2@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=tomasz.dziendzielski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.