From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
Robert VanVossen <Robert.VanVossen@dornerworks.com>,
Dario Faggioli <dfaggioli@suse.com>,
Julien Grall <julien.grall@arm.com>,
Joshua Whitehead <josh.whitehead@dornerworks.com>,
Meng Xu <mengxu@cis.upenn.edu>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH RFC 31/49] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers
Date: Mon, 1 Apr 2019 10:46:28 +0200 [thread overview]
Message-ID: <fee3c0da-e38a-99f1-f137-059fa65e0e1f@suse.com> (raw)
On 01/04/2019 10:10, Jan Beulich wrote:
>>>> On 30.03.19 at 11:22, <jgross@suse.com> wrote:
>> On 29/03/2019 20:36, Andrew Cooper wrote:
>>> In practice, all this flag does is permit the use of VCPUOP_get_physid,
>>> disallow the use of vcpu_set_hard_affinity(), and allow dom0 to attempt
>>> to actually write to MSR_AMD64_NB_CFG, MSR_FAM10H_MMIO_CONF_BASE,
>>> MSR_IA32_UCODE_REV, MSR_IA32_THERM_CONTROL and
>>> MSR_IA32_ENERGY_PERF_BIAS, rather than having the write silently discarded.
>>>
>>> Dom0's use of those MSRs is dubious at best, and disabled by default,
>>> *and* when active, also cross-checks with the hard affinity mask. Does
>>> anyone use dom0_vcpus_pin in production?
>>
>> I have seen it on customer systems.
>
> Same here, but I've never seen it used for a good reason.
>
>>> I think there is quite a lot of value in getting rid of d->is_pinned and
>>> is_pinned_vcpu() entirely, with will remove an extreme
>>> corner-case-x86-ism out of the common code.
>
> I think its origin was "cpufreq=dom0-kernel", which I think should go
> away with it then.
Fine with me. Another candidate for a later cleanup, I guess.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2019-04-01 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 8:46 Juergen Gross [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-29 15:08 [PATCH RFC 00/49] xen: add core scheduling support Juergen Gross
2019-03-29 15:09 ` [PATCH RFC 31/49] xen/sched: use sched_resource cpu instead smp_processor_id in schedulers Juergen Gross
2019-03-29 19:36 ` Andrew Cooper
2019-03-30 10:22 ` Juergen Gross
2019-04-01 8:10 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee3c0da-e38a-99f1-f137-059fa65e0e1f@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=Robert.VanVossen@dornerworks.com \
--cc=andrew.cooper3@citrix.com \
--cc=dfaggioli@suse.com \
--cc=josh.whitehead@dornerworks.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=mengxu@cis.upenn.edu \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.