From: Jens Axboe <axboe@kernel.dk>
To: Nathan Chancellor <natechancellor@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] pata_atiixp: Remove unnecessary parentheses
Date: Tue, 11 Sep 2018 16:57:21 -0600 [thread overview]
Message-ID: <fee3ed2a-4aa6-e9d8-dbcd-8f1f8ee67d06@kernel.dk> (raw)
In-Reply-To: <20180911214338.1109-1-natechancellor@gmail.com>
On 9/11/18 3:43 PM, Nathan Chancellor wrote:
> Clang warns when more than one set of parentheses is used for a
> single conditional statement:
>
> drivers/ata/pata_atiixp.c:282:19: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/ata/pata_atiixp.c:282:19: note: remove extraneous parentheses
> around the comparison to silence this warning
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ~ ^ ~
> drivers/ata/pata_atiixp.c:282:19: note: use '=' to turn this equality
> comparison into an assignment
> if((pdev->device == PCI_DEVICE_ID_ATI_IXP600_IDE))
> ^~
> =
> 1 warning generated.
Applied for 4.20, thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-09-11 22:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 21:43 [PATCH] pata_atiixp: Remove unnecessary parentheses Nathan Chancellor
2018-09-11 21:49 ` Nick Desaulniers
2018-09-11 22:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee3ed2a-4aa6-e9d8-dbcd-8f1f8ee67d06@kernel.dk \
--to=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.