From: Damien Le Moal <dlemoal@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Rick Wertenbroek <rick.wertenbroek@gmail.com>
Cc: "rick.wertenbroek@heig-vd.ch" <rick.wertenbroek@heig-vd.ch>,
"alberto.dassatti@heig-vd.ch" <alberto.dassatti@heig-vd.ch>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Keith Busch" <kbusch@kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Shin'ichiro Kawasaki" <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH v2 1/1] nvmet: pci-epf: Do not complete commands twice if nvmet_req_init() fails
Date: Thu, 17 Jul 2025 07:42:12 +0900 [thread overview]
Message-ID: <fee4f767-301b-4650-8607-28fce17924ad@kernel.org> (raw)
In-Reply-To: <ba009e79-e82a-478d-bf2b-52b964141c11@nvidia.com>
On 7/17/25 06:56, Chaitanya Kulkarni wrote:
> Good catch, looks good, I wish we have tests for this part of target
> to it will get tested on regular basis, not the requirement, just
> a thought.
qemu does not have a PCI endpoint capable controller device and you cannot link
2 VMs to communicate over PCIe (one VM as host the other as endpoint). So unless
you get a PCIe-endpoint capable board, you cannot run this driver easily.
We can add a blktest case for sending an unsupported command though. That is
easy to do. But FYI, right now, running blktest/nvme group against a pci-epf
device, we get a hang... Shin'ichiro is looking into that.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-07-16 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 11:15 [PATCH v2 0/1] nvmet: pci-epf: Do not complete commands twice if nvmet_req_init() fails Rick Wertenbroek
2025-07-16 11:15 ` [PATCH v2 1/1] " Rick Wertenbroek
2025-07-16 21:56 ` Chaitanya Kulkarni
2025-07-16 22:42 ` Damien Le Moal [this message]
2025-07-17 11:40 ` [PATCH v2 0/1] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee4f767-301b-4650-8607-28fce17924ad@kernel.org \
--to=dlemoal@kernel.org \
--cc=alberto.dassatti@heig-vd.ch \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mani@kernel.org \
--cc=rick.wertenbroek@gmail.com \
--cc=rick.wertenbroek@heig-vd.ch \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.