From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 213E9C61D90 for ; Tue, 21 Nov 2023 08:17:17 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.637557.993456 (Exim 4.92) (envelope-from ) id 1r5LwI-0006sc-NW; Tue, 21 Nov 2023 08:16:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 637557.993456; Tue, 21 Nov 2023 08:16:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r5LwI-0006sV-Kz; Tue, 21 Nov 2023 08:16:58 +0000 Received: by outflank-mailman (input) for mailman id 637557; Tue, 21 Nov 2023 08:16:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r5LwI-0006sP-4Z for xen-devel@lists.xenproject.org; Tue, 21 Nov 2023 08:16:58 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 559fcc3e-8846-11ee-9b0e-b553b5be7939; Tue, 21 Nov 2023 09:16:56 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id C59A94EE073A; Tue, 21 Nov 2023 09:16:55 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 559fcc3e-8846-11ee-9b0e-b553b5be7939 MIME-Version: 1.0 Date: Tue, 21 Nov 2023 09:16:55 +0100 From: Nicola Vetrini To: Julien Grall Cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, bertrand.marquis@arm.com, George Dunlap , Wei Liu , Volodymyr Babchuk Subject: Re: [XEN PATCH v3] xen: replace occurrences of SAF-1-safe with asmlinkage attribute In-Reply-To: References: <991883873b73e644ccaf8114a80331c0@bugseng.com> <40a3918e-730f-48b9-924f-d8707b197e14@xen.org> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2023-11-20 11:27, Julien Grall wrote: > Hi Nicola, > > On 20/11/2023 08:39, Nicola Vetrini wrote: >> On 2023-11-17 20:15, Julien Grall wrote: >>> Hi Nicola, >>> >>> On 16/11/2023 09:15, Nicola Vetrini wrote: >>>> On 2023-11-16 10:08, Nicola Vetrini wrote: >>>>> The comment-based justifications for MISRA C:2012 Rule 8.4 are >>>>> replaced >>>>> by the asmlinkage pseudo-attribute, for the sake of uniformity. >>>>> >>>>> Add missing 'xen/compiler.h' #include-s where needed. >>>>> >>>>> The text in docs/misra/deviations.rst and docs/misra/safe.json >>>>> is modified to reflect this change. >>>>> >>>>> Signed-off-by: Nicola Vetrini >>>>> --- >>>>> This patch should be applied after patch 2 of this series. >>>>> The request made by Julien to update the wording is >>>>> contained in the present patch. >>>>> https://lore.kernel.org/all/9ad7f6210c15f520297aac00e8af0e64@bugseng.com/ >>>>> >>>>> Concerns about efi_multiboot2 will be dealt with separately. >>>>> >>>>> Changes in v2: >>>>> - Edit safe.json. >>>>> - Remove mention of SAF-1-safe in deviations.rst. >>>>> Changes in v3: >>>>> - Sorted #include-s and rebased against >>>>> 7ad0c774e474 ("x86/boot: tidy #include-s") >>>>> --- >>>>>  docs/misra/deviations.rst   |  5 ++--- >>>>>  docs/misra/safe.json        |  2 +- >>>>>  xen/arch/arm/cpuerrata.c    |  7 +++---- >>>>>  xen/arch/arm/setup.c        |  5 ++--- >>>>>  xen/arch/arm/smpboot.c      |  3 +-- >>>>>  xen/arch/arm/traps.c        | 21 +++++++-------------- >>>>>  xen/arch/x86/boot/cmdline.c |  5 +++-- >>>>>  xen/arch/x86/boot/reloc.c   |  6 +++--- >>>>>  xen/arch/x86/extable.c      |  3 +-- >>>>>  xen/arch/x86/setup.c        |  3 +-- >>>>>  xen/arch/x86/traps.c        | 27 +++++++++------------------ >>>>>  xen/common/efi/boot.c       |  5 ++--- >>>>>  12 files changed, 35 insertions(+), 57 deletions(-) >>>>> >>>> >>>> In hindsight I should have added an >>>> >>>> Acked-by: Julien Grall >>>> >>>> given that the comment has been addressed in my opinion. >>> >>> I am a bit confused how you considered it was addressed. I see no >>> update in safe.json when I clearly asked for some (I wouldn't have >>> bothered to comment in v2 otherwise and just gave an ack). >>> >> >> I did update safe.json like so: >> >> -            "text": "Functions and variables used only by asm modules >> do not need to have a visible declaration prior to their definition." >> +            "text": "Not used anymore." >> >> but given what you wrote below, maybe you wanted this in the series >> [1], right? > > No. In series [1], we still need a proper description for SAF-1 as > there are still some use in the codebase. So it was correct to have > this hunk in this series. > > What I was asking in series [1], it to reword: > > + - Functions and variables used only by asm modules are either > marked with > + the `asmlinkage` macro or with a SAF-1-safe textual deviation > + (see safe.json). > > > to something like: > > - Functions and variables used only by asm modules are marked with the > `asmlinkage macro``. This may also be marked with the now deprecated > SAF-1-safe textual deviation (see safe.json). > >> >>> To be explicit, I requested to: >>>   1. update the description in [2] to clarify that SAF-1 is >>> deprecated. >>>   2. This patch is rebased on top and therefore remove completely the >>> mention of SAF-1. >>> >>> I am well-aware that the end result is technically the same. But >>> patches are meant to be self-contained so if we revert the latest, >>> then the meaning is still the same. >>> >>> This patch is unlikely to be removed and this is now the nth time I >>> asked it the same (maybe it was not clear enough?). So I am going to >>> content with the current proposal because this is not worth to go >>> further. But I will at least express my discontent how this is >>> handled. >>> >> >> I misunderstood your previous comments then. When you commented on v2 >> I surmised that you were ok with this patch condensing all the >> shuffling. Clearly this was not the case, but I also want to point out >> that. Given that [2] hasn't been committed yet either, then I can do >> what you asked. > > No need for this time. > > Cheers, Ok, thanks for the patience. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)