From: Eduard Zingerman <eddyz87@gmail.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Emil Tsalapatis <emil@etsalapatis.com>,
kkd@meta.com, kernel-team@meta.com
Subject: Re: [PATCH bpf-next v1 1/2] bpf: Fix sleepable context checks and remove in_sleepable helper
Date: Thu, 06 Aug 2026 13:31:56 -0700 [thread overview]
Message-ID: <fef13656df34d6ccf0e820d99e8f5e87b9fa8d56.camel@gmail.com> (raw)
In-Reply-To: <20260806164049.3158887-2-memxor@gmail.com>
On Thu, 2026-08-06 at 18:40 +0200, Kumar Kartikeya Dwivedi wrote:
...
> @@ -10258,7 +10253,7 @@ static inline bool in_sleepable_context(struct bpf_verifier_env *env)
> !env->cur_state->active_preempt_locks &&
> !env->cur_state->active_locks &&
> !env->cur_state->active_irq_id &&
> - in_sleepable(env);
> + env->cur_state->in_sleepable;
> }
The in_rcu_cs() and in_sleepable_context() are complementary:
env->cur_state->active_rcu_locks || !env->cur_state->active_rcu_locks &&
env->cur_state->active_preempt_locks || !env->cur_state->active_preempt_locks &&
env->cur_state->active_locks || !env->cur_state->active_locks &&
env->cur_state->active_irq_id || !env->cur_state->active_irq_id &&
!env->cur_state->in_sleepable; env->cur_state->in_sleepable;
Should the one be expressed through the other?
...
next prev parent reply other threads:[~2026-08-06 20:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 16:40 [PATCH bpf-next v1 0/2] Fix sleepable context checks in verifier Kumar Kartikeya Dwivedi
2026-08-06 16:40 ` [PATCH bpf-next v1 1/2] bpf: Fix sleepable context checks and remove in_sleepable helper Kumar Kartikeya Dwivedi
2026-08-06 17:14 ` sashiko-bot
2026-08-06 20:31 ` Eduard Zingerman [this message]
2026-08-06 21:22 ` Kumar Kartikeya Dwivedi
2026-08-06 22:17 ` Eduard Zingerman
2026-08-06 21:10 ` Eduard Zingerman
2026-08-06 21:20 ` Kumar Kartikeya Dwivedi
2026-08-06 21:46 ` Kumar Kartikeya Dwivedi
2026-08-06 16:40 ` [PATCH bpf-next v1 2/2] selftests/bpf: Test sleepable context distinctions Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fef13656df34d6ccf0e820d99e8f5e87b9fa8d56.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=kernel-team@meta.com \
--cc=kkd@meta.com \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.