All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: buildroot@buildroot.org, ibai.erkiaga-elorza@amd.com,
	luca.ceresoli@bootlin.com, brandon.maier@collins.com,
	thomas.petazzoni@bootlin.com, romain.naour@smile.fr,
	michal.simek@amd.com, romain.naour@gmail.com
Subject: Re: [Buildroot] [PATCH v1 1/1] package/bootgen: bump to xilinx_v2026.1
Date: Tue, 16 Jun 2026 20:41:09 +0200	[thread overview]
Message-ID: <fefb2dbfced24bda58bd733bef949fbd@free.fr> (raw)
In-Reply-To: <20260616055422.3688535-1-neal.frager@amd.com>

Hi Neal,

Thanks for the patch. I have one comment, see below.

On 16/06/2026 07:54, Neal Frager via buildroot wrote:
> Bump bootgen to xilinx_v2026.1 release.
> 
> The following patches are now included and can be removed:
> 0001-lms-hash-sigs-hss_param.c-add-stdio.h-include.patch
> 0002-flexlexer-use-embedded-win_include-flexlexer.h.patch
> 
> bootgen xilinx_v2026.1 now requires C++ version 14, so the build 
> command has
> been updated to reflect this.

Since this host package has a Config.in.host Kconfig entry,
this new C++14 requirement could be reflected there. For ex:

config BR2_PACKAGE_HOST_BOOTGEN
	bool "host bootgen"
	depends on BR2_HOST_GCC_AT_LEAST_5 # C++14
	...

comment "host-bootgen needs a host gcc >= 5"
	depends on !BR2_HOST_GCC_AT_LEAST_5

Could you send a v2 with those changes please?

> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-06-16 18:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16  5:54 [Buildroot] [PATCH v1 1/1] package/bootgen: bump to xilinx_v2026.1 Neal Frager via buildroot
2026-06-16 18:41 ` Julien Olivain via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fefb2dbfced24bda58bd733bef949fbd@free.fr \
    --to=buildroot@buildroot.org \
    --cc=brandon.maier@collins.com \
    --cc=ibai.erkiaga-elorza@amd.com \
    --cc=ju.o@free.fr \
    --cc=luca.ceresoli@bootlin.com \
    --cc=michal.simek@amd.com \
    --cc=neal.frager@amd.com \
    --cc=romain.naour@gmail.com \
    --cc=romain.naour@smile.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.