From: Hans de Goede <hansg@kernel.org>
To: NanamiKite <nanami@yosoro.hk>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: cm32181: Add support for CM32183
Date: Wed, 18 Nov 2026 16:42:37 +0100 [thread overview]
Message-ID: <fefe83ac-4749-4564-b76f-d89bf491d8af@kernel.org> (raw)
In-Reply-To: <tencent_E90EB0AF3888FA057AA5F6008C16C610650A@qq.com>
Hi,
On 18-Nov-26 16:11, NanamiKite wrote:
> On the H3C MegaBook 14, the ACPI CPLM3218:00 node declares a Capella
> CM32183 ambient light sensor (CPM0 device ID 0x7db7 / 32183) at I2C
> address 0x29. Reading CM32181_REG_ADDR_ID (0x07) returns 0xc383, with
> chip ID 0x83 in the lower byte, causing cm32181_reg_init() to fail with
> -ENODEV.
>
> The CM32183 uses the same register layout and ACPI CPM0/CPM1 tables as
> the CM32181 and CM32182. Add chip ID 0x83 to cm32181_reg_init().
>
> Cc: stable@vger.kernel.org
> Signed-off-by: NanamiKite <nanami@yosoro.hk>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
Regards,
Hans
> ---
> drivers/iio/light/cm32181.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index b32a940..aaf1af3 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -200,6 +200,7 @@ static int cm32181_reg_init(struct cm32181_chip *cm32181)
> break;
> case 0x81: /* CM32181 */
> case 0x82: /* CM32182, fully compat. with CM32181 */
> + case 0x83: /* CM32183, fully compat. with CM32181 */
> cm32181->num_als_it = ARRAY_SIZE(cm32181_als_it_bits);
> cm32181->als_it_bits = cm32181_als_it_bits;
> cm32181->als_it_values = cm32181_als_it_values;
next prev parent reply other threads:[~2026-11-18 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 15:11 [PATCH] iio: light: cm32181: Add support for CM32183 NanamiKite
2026-11-18 15:18 ` Joshua Crofts
2026-11-18 15:42 ` Hans de Goede [this message]
2026-11-19 1:44 ` Jonathan Cameron
2026-11-19 2:33 ` NanamiKite
2026-11-19 9:06 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fefe83ac-4749-4564-b76f-d89bf491d8af@kernel.org \
--to=hansg@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nanami@yosoro.hk \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.