From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBDBAC36010 for ; Sat, 5 Apr 2025 08:59:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0zMj-0005ZD-J9; Sat, 05 Apr 2025 04:59:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0zMh-0005Yf-KG for qemu-riscv@nongnu.org; Sat, 05 Apr 2025 04:58:59 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u0zMc-0006CO-V8 for qemu-riscv@nongnu.org; Sat, 05 Apr 2025 04:58:59 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-22401f4d35aso30318475ad.2 for ; Sat, 05 Apr 2025 01:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1743843533; x=1744448333; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=67DYcBHee7/3xYSIKdYB6rMYy5HUKFBkyEAH4ydb0pw=; b=X/ZdQwSLxrvF3Tofbzh/uMNzzx8kuf70v8ppF2g1kZ1yecHQt4d5Wc03zznHy4zmt7 PXQ2n+wS8uJT6+bPsfmUe4ujuxLsuoVIO5r5dVEvRF8YVC0/q6NTUw1rbT30rVTwtTVn byQOMRGI8TXwJYOQMRYRaCc7pbq3LQU+xZqYFCCzC6RD9Igee6BuXXshI0JZ4oQRG5V6 uKZVPevQkxF2VTD3VcB12l7o/US6JgYPaxspkicl5NsmLbSDoPuYVE2wdM9gg+8HPJZk OwLYHOthtsN3Ty2CdpxKExoWY073YamYHRipC+RbNykywyi/GLVW18nlu+cUBPLkHq5v sXnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743843533; x=1744448333; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=67DYcBHee7/3xYSIKdYB6rMYy5HUKFBkyEAH4ydb0pw=; b=B+dqUdCCru7IeIyT9AgkzGEMIbnR81HhdBoadN9RZHUlttihlvi0zVpXHtzIsNCfHE +tuJ7xbmsPHh2uhXVdquRVHD4Giz2gxQbFr1z0Nmn1FbF6DMyo84AxMpAyPmP5ppZhZh XYG+EBQj8SxLi9roZtCVVazEkd5Je197vOagzlMXPetYk6YjIzCAZsuCYF40zs7gM0we gbXsOEjOtzgtAoXyGmSXlXcyqAh6odPuDKthWCKQzwwF8MkYieVpqh0+LG7qnbD5JksQ eFHjaTn7s60qc2f67HXxzBZ4I1ACfxtTPEFq/z5W5OsEvk2CDtJvh8mk9kfCfUaeO7i2 0rQA== X-Forwarded-Encrypted: i=1; AJvYcCWcxLiGix2Fuw35v8h0NOueEVbk6ep24vXmBoUbmwFT/aK3k5qPouD75YJ7vmiwt0fqFvZRE3DC9rec@nongnu.org X-Gm-Message-State: AOJu0Yw6EV81kuxDaI8dVU8z47lm/ZWrUl10pIQRQjOww8+66D5jBqkk JyYkA3Eeu9rgMRVKBEbObOEsx0b3+8Amepx4e9LeDSnd/oiFFpM0wolmmNxNnsA= X-Gm-Gg: ASbGncuUWJ6Nlv7l/yPDwXQS5ayqzwv9E44gtu3BXxbcvo2/5zHj+BUqETm+uphfXfN SJw72J3bA8fdG+KyUS+2XC4gcbWgSrBYJTXNiD3mkudZMJ49/jK+KEzbITDsdTt9ZVLAYonSmZR 58tH+hWdva0+SNuNoo+A9dKBR3ZML92QYneao8WRU6bHgjYpIOnBA3m3559AG9vQVAyCPqhw7so gsqepyqxS6Gk+0+ug510kISpfIvxVvyyTm+g51g8PiXD3a5aP5+tXVblgHndsYUEI6jfsLtMtvC tWohfkTCHHVpxPnl6aGROZRz1H2oWMfV64sGk3BQo5v2CDU5hYjs0CT06HSDEvc2sb2POJE= X-Google-Smtp-Source: AGHT+IFoJpA9jnJLiy3QR50f/Qumum5uQS3Hle2H/3aownlJyB1BkH+duztLEve18xY/KvcM2OyxTg== X-Received: by 2002:a17:903:234f:b0:220:fe50:5b44 with SMTP id d9443c01a7336-22a9553c0d1mr30513815ad.31.1743843533183; Sat, 05 Apr 2025 01:58:53 -0700 (PDT) Received: from [192.168.68.110] ([177.170.227.223]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2297866cf04sm45224625ad.161.2025.04.05.01.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Apr 2025 01:58:52 -0700 (PDT) Message-ID: Date: Sat, 5 Apr 2025 05:58:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/12] target/riscv: rvv: Add CHECK arg to GEN_OPFVF_WIDEN_TRANS To: Max Chou , qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Weiwei Li , Liu Zhiwei , antonb@tenstorrent.com References: <20250329144446.2619306-1-max.chou@sifive.com> <20250329144446.2619306-3-max.chou@sifive.com> Content-Language: en-US From: Daniel Henrique Barboza In-Reply-To: <20250329144446.2619306-3-max.chou@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 3/29/25 11:44 AM, Max Chou wrote: > From: Anton Blanchard > > Signed-off-by: Anton Blanchard > Signed-off-by: Max Chou > --- Reviewed-by: Daniel Henrique Barboza > target/riscv/insn_trans/trans_rvv.c.inc | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_trans/trans_rvv.c.inc > index 20b1cb127b4..e630f8661e1 100644 > --- a/target/riscv/insn_trans/trans_rvv.c.inc > +++ b/target/riscv/insn_trans/trans_rvv.c.inc > @@ -2403,10 +2403,10 @@ static bool opfvf_widen_check(DisasContext *s, arg_rmrr *a) > } > > /* OPFVF with WIDEN */ > -#define GEN_OPFVF_WIDEN_TRANS(NAME) \ > +#define GEN_OPFVF_WIDEN_TRANS(NAME, CHECK) \ > static bool trans_##NAME(DisasContext *s, arg_rmrr *a) \ > { \ > - if (opfvf_widen_check(s, a)) { \ > + if (CHECK(s, a)) { \ > uint32_t data = 0; \ > static gen_helper_opfvf *const fns[2] = { \ > gen_helper_##NAME##_h, gen_helper_##NAME##_w, \ > @@ -2422,8 +2422,8 @@ static bool trans_##NAME(DisasContext *s, arg_rmrr *a) \ > return false; \ > } > > -GEN_OPFVF_WIDEN_TRANS(vfwadd_vf) > -GEN_OPFVF_WIDEN_TRANS(vfwsub_vf) > +GEN_OPFVF_WIDEN_TRANS(vfwadd_vf, opfvf_widen_check) > +GEN_OPFVF_WIDEN_TRANS(vfwsub_vf, opfvf_widen_check) > > static bool opfwv_widen_check(DisasContext *s, arg_rmrr *a) > { > @@ -2505,7 +2505,7 @@ GEN_OPFVF_TRANS(vfrdiv_vf, opfvf_check) > > /* Vector Widening Floating-Point Multiply */ > GEN_OPFVV_WIDEN_TRANS(vfwmul_vv, opfvv_widen_check) > -GEN_OPFVF_WIDEN_TRANS(vfwmul_vf) > +GEN_OPFVF_WIDEN_TRANS(vfwmul_vf, opfvf_widen_check) > > /* Vector Single-Width Floating-Point Fused Multiply-Add Instructions */ > GEN_OPFVV_TRANS(vfmacc_vv, opfvv_check) > @@ -2530,10 +2530,10 @@ GEN_OPFVV_WIDEN_TRANS(vfwmacc_vv, opfvv_widen_check) > GEN_OPFVV_WIDEN_TRANS(vfwnmacc_vv, opfvv_widen_check) > GEN_OPFVV_WIDEN_TRANS(vfwmsac_vv, opfvv_widen_check) > GEN_OPFVV_WIDEN_TRANS(vfwnmsac_vv, opfvv_widen_check) > -GEN_OPFVF_WIDEN_TRANS(vfwmacc_vf) > -GEN_OPFVF_WIDEN_TRANS(vfwnmacc_vf) > -GEN_OPFVF_WIDEN_TRANS(vfwmsac_vf) > -GEN_OPFVF_WIDEN_TRANS(vfwnmsac_vf) > +GEN_OPFVF_WIDEN_TRANS(vfwmacc_vf, opfvf_widen_check) > +GEN_OPFVF_WIDEN_TRANS(vfwnmacc_vf, opfvf_widen_check) > +GEN_OPFVF_WIDEN_TRANS(vfwmsac_vf, opfvf_widen_check) > +GEN_OPFVF_WIDEN_TRANS(vfwnmsac_vf, opfvf_widen_check) > > /* Vector Floating-Point Square-Root Instruction */ >