From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 479ADC83F1B for ; Wed, 16 Jul 2025 10:58:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB3A310E122; Wed, 16 Jul 2025 10:58:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="VWD89kvO"; dkim-atps=neutral Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2075.outbound.protection.outlook.com [40.107.93.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06FCD10E122 for ; Wed, 16 Jul 2025 10:58:39 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=faKk6NLnJWJ0LyQO9KZz+ydaS0CS2L03Xe/EeMGL5EUpv655MhSVM2UJDkr9JUYx2Uv/xOcQswFuv1GuSPDLyPEVKzKeB/t28wQ75f3Yy7OZ8ETf4iKmJ/fK142QOzcFyn9SrrVHN7MUGfleamrprpJgLjcDKHIm0eAa5wCTG18on2C3G0XS6EbT75bNHCc2VKHA/de3CG/POvfiA6ULKzGEIdmerK5o11VkPYtvz/ccJKq2IVpFObnmteMqTrWZ95/Q9ZkiYxR158fKEWhj+sALuJkIlMvAYwunUSLJJbYb0wRNfYW/wPvaQaAKVH5etp/NMQfUQW4Fs2f0JoYm+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5uC9JgT3wzvq22wOSZ2NhFwoQx/SY37Z9+XkKHSHehU=; b=Pcz1EjYgqTM1RgD6/luiM4NPdnrChOtipZ+6omgJCKi+SNBgtps4FN9xD39PoO5vyj+ed1/jJCTTCkRh4dAR535MbelMUBi5RlB808h83i7FtBntFEXpwpVXQE4yqwY8F4cc/eT6wTpGOkY7wu9eadg77W9G3cCPfuVuMMchCeMBv7VJcDm8Uz047NZJvkwPfd+hJUmru8o/ejNYrCVGWgJveEqZ2IGWmcHFgwU8+/+wnIlLyL9AMVLvPAEKJXDHLKa75PJG3w7k8k15z1BKKhy0BGAS1HWzAydgX9KQkpqB0ESxfEc/6fQLIYbkS71icMPbGHJr3M8G0jYSp9XIkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5uC9JgT3wzvq22wOSZ2NhFwoQx/SY37Z9+XkKHSHehU=; b=VWD89kvOr6UfCq2XrPYGyUmzLr56EEQR4LLkvQCXQ6zoGxnmW9KHOyFUyj+yp5v9jwZpM65a8lT1UFqfLO94wzRru7KOzOhqxBbzR70cksFO0SQoMwYgfzKzp/uNQ2T74HWldOXf78yOfIDyMd0LUfR0EJ7On6fNtndvs1twrLI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB5685.namprd12.prod.outlook.com (2603:10b6:510:13c::22) by DS2PR12MB9798.namprd12.prod.outlook.com (2603:10b6:8:2b9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.27; Wed, 16 Jul 2025 10:58:33 +0000 Received: from PH7PR12MB5685.namprd12.prod.outlook.com ([fe80::46fb:96f2:7667:7ca5]) by PH7PR12MB5685.namprd12.prod.outlook.com ([fe80::46fb:96f2:7667:7ca5%5]) with mapi id 15.20.8901.033; Wed, 16 Jul 2025 10:58:33 +0000 Message-ID: Date: Wed, 16 Jul 2025 12:58:28 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/sched: Remove optimization that causes hang when killing dependent jobs To: phasta@kernel.org, =?UTF-8?Q?Michel_D=C3=A4nzer?= , "cao, lin" , "dri-devel@lists.freedesktop.org" Cc: "Yin, ZhenGuo (Chris)" , "Deng, Emily" , "dakr@kernel.org" , "matthew.brost@intel.com" , Greg Kroah-Hartman , Sasha Levin References: <20250715135033.706126-1-lincao12@amd.com> <49d822fc0f46e0fdeaccaeb2fbb1ade1c5cb1e5d.camel@mailbox.org> Content-Language: en-US From: =?UTF-8?Q?Christian_K=C3=B6nig?= In-Reply-To: <49d822fc0f46e0fdeaccaeb2fbb1ade1c5cb1e5d.camel@mailbox.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::25) To PH7PR12MB5685.namprd12.prod.outlook.com (2603:10b6:510:13c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB5685:EE_|DS2PR12MB9798:EE_ X-MS-Office365-Filtering-Correlation-Id: eba63a0c-a2b6-40fc-b54c-08ddc457b48f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NVM1R1BWZ094WWtEUE9KWUpvRExyckk2WWtwL0NLT3pWVXlIc01UMmhHUERo?= =?utf-8?B?ZWx2UVorWUxWcmJJcFIzR25odTQrQ3dlTUgxMTB3dkw1c2JkYkd2SUh0VG9p?= =?utf-8?B?d3RMWTF6L0RlT1FTL3JLVERnQ3p5djB6MVNQY3A3VWE5bU5jdEJyLzl2MjJl?= =?utf-8?B?UGRXY0lpeU9QNVc2elpUVTRldXdiajRtZkQxZG9Oc0NDWTZnbDlRM0Jvak1m?= =?utf-8?B?V3lLUEk0bDJrZzlJWUVVMDdvQ1dWblAvaFUvaGtRcXBISlVkdGVKTjk1VWEy?= =?utf-8?B?S1BtZXhqSXg4cjMvM0duMWhQZDIzaWNsVlF0eksyQlZJN2N2eU9sVDFIS05F?= =?utf-8?B?aUpUY2sweXVQMHZlWGdqSDdMeTM0bitsU25Cc2taSkZPbkVlUjl1QUJ0d0Fk?= =?utf-8?B?ZGZVekYwTEt2N2E1VnhQTDdIcWZ2d2Q0QmR0a2pQV0QyN0Nxb0lJM0VRd2lv?= =?utf-8?B?OGU3RXluZEthVUJjVkVMdVJlVzIrcGlUbkRCN29wNDN5MU5MdGU0czNaUTds?= =?utf-8?B?cjBuOXJsNitIUzVGNC9xTlp5emp3YUJWU3FLMEFBWTk3bXRlcWpYOVZieHRo?= =?utf-8?B?ZzY1d3VtcjZjNlVJczV0bnphSVJJNVZ2eWtpMGd5WjZMVUVsUmJ2K1VVTEJp?= =?utf-8?B?MUZUelR6dTVZTkM1ZGxSNjdSWi9ZRXFxZGMyWkp6S2VoN2RGeHJNSi9kU3N3?= =?utf-8?B?VldqdlpXU0ZIUHlmWFZHSXl1Q2k2cGxyaEJhQ1dHYzhvMW5kUXIrN0RkVGEx?= =?utf-8?B?R1g5V2VocXV5bDVaeWZwNjNtVWFSVnNSVTFzV1d5NkF1eC9ScTVqc0EvQ0dN?= =?utf-8?B?MXRsdFU0Mi9yaVk4K2xSdWJaK3RGUXEwc0VJNXpnRkYyNGFNVHlKbHFHbkMx?= =?utf-8?B?Z3VVdmhOUDBQYlMvQkw4Z3Y0anpuOWpiNWM4by9JNXJLMUpFdU8weGt3bFFu?= =?utf-8?B?VDFtV0l5SHNFb0JnSEFLejNsWjRKMS9aNzVDbm50NTM2c3RXOTlKeUEweHFo?= =?utf-8?B?WXVOOENDNmFsOTBrc20vRVVmUVloTTJMdURyMWs2QXVHckFaL05waWg0MFBN?= =?utf-8?B?VnFBWkdEdy93anozVzBXVCtqd2x5ZTBUN0hDVlhsVjhRVXpLbHdJanJyNWY1?= =?utf-8?B?cGs5RWhkVzVTWm1tcU13c3Y4bXR6WHFpSmdtcWZuUWlia1JyVzVwRGRLa29p?= =?utf-8?B?TmVQbXA3OUFsTGxUUUdYOU5Ic3dzbi9uWndLaEtBQVVrSHVSeExiK2JaaEt4?= =?utf-8?B?Nms1aE1QL2ZqOGttaStHZTdkaHVYS1FGMHUvQkE0SU1QSmgzUFpkYnhZRDhS?= =?utf-8?B?WldjcEZUTnVLc3ZCSWFJWGRlN3BDbFJIWnk4QWhmc2JTT1gxQ3ZGVW9Fdlp2?= =?utf-8?B?UEVublZNU3Z5dzZCdTFERXBSZDVsOWw3MWQycjh6Ym5NeTZTNEFlY2g4QzM2?= =?utf-8?B?SVluTzhndXJDSmsvTFRVMWdwVmdyZWFpVWM4dC80M0NiNjZ4R2h3Y1pDdjJS?= =?utf-8?B?N0JzYjhreTBzdXBERFBnejVPQ1NSYWpZVXRTdTAwcGtRM2YwWXlMT3VkcmVp?= =?utf-8?B?aS9CY1VIWE5rQXlNN1ZvUlZxTWZpbmlrbWR5OEtqcld0eXk0ZHlhOEluKzlE?= =?utf-8?B?N0FZd1ZVdXQwdjkyakIwUFBoVjJudm9Ia0daZG4vUTZJTThtMkRQbGR6bGhS?= =?utf-8?B?dis2bnZ2RzhJc1I2dFV0cDI2eE5nZnAvK3NEeXgzMmpUSks2UngwcXI2OUdH?= =?utf-8?B?MmRYRzBGWkVwVGY1MnpEY1BYSll0UzVxZGYvbG5vS2cxOXdWdUMxaU1vREZy?= =?utf-8?B?YmJ2WHArOGYzMy92T1ZBNmFMQ2xBZnh6WElxUytGWUxYMGQweWpoU0szSEE3?= =?utf-8?B?dUdhWGNGWWpCU2ZHN2g5VnZ6dXhkZ2tyNktxNGkxZWFzNEpKYTRsMi9BdVpX?= =?utf-8?Q?ilev4Vkz514=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB5685.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVU4T0Y1dWJtT2VuNExhSERmRnJMVzRLQU9iRkdoUXJGZzJCb2g1Tm1FYUNE?= =?utf-8?B?UjFVTDd5NDZVcjNTaGZrMWtmQkhsd3RXREk2eVVpOGZ3MEZLZVd6VHdUVnh2?= =?utf-8?B?UTl6MVNmTXNYdnpOeWNYK1doYnd1U3lVRDFXc21CL3NuQ2NIektDZ0RYMzE0?= =?utf-8?B?M0RDNGlENkFvcnVHUyt3LzNZaGxRNkFDUWpaNTdBZGJ4UFp2bnJmOEE5RVli?= =?utf-8?B?dTI0bFg2Tjhhdk9SZlMxMC9MOTA3MDQwa3VTZkxVdVBMaXVrZ1MwbWdZSW0x?= =?utf-8?B?NUZIRjdsSXZWQ1RzRjVwbVVjT2o4dzdYQzhPRmhrcDk5dXNRSVRrZkN2RkpM?= =?utf-8?B?dnpNNE1IN3cyZWJWcU13bE1XZ2phSDl6dnpuWHlVMkdoNWh0MWNaR1cwc3ha?= =?utf-8?B?bUV2bzJyK2NBTmRhMXNmT1BYNjNheVVvOGlxbXlsRUZFUXltblBwL0xlU0p1?= =?utf-8?B?R2JTUGlPZGJJSHJ6ZG9BUXVqUHpJTGtrdThxallia2J6VzVLc2J6OVZkZTdj?= =?utf-8?B?bC9ydXRCSUt0Z1NjL2lnQTV1YmxDTWNQY3paVDlkTGptQzJDaHNxU08wanc3?= =?utf-8?B?NWxWQVBEeHdtSUdqeHFJRUVWaVhHTTI1MjlNVm1RMEsrL290b3MrSHJZbUpi?= =?utf-8?B?NVBsSStIUDlEcWw2cXR5L2oyQlFDdGdKaEhsMlFPOUpOTGZGMWNxeDAzOEY4?= =?utf-8?B?cFNXR1RNcUhPUlVUQW5MajlhaWRYSHZPNkw3RU5DSDJ1VExqYVRZWjQ5bDNn?= =?utf-8?B?bm11WDB3c2NNY0FBby9PZ1ZWTEpBVmd6Y0lmK3NKdFIwQkhwOWNkc0hiOFVK?= =?utf-8?B?a3dQQWx0NFdnNy84ZW93bTE0SWVMcis2R2JsSU02dXVzUWFrZm5kcjZ2VWdI?= =?utf-8?B?MGx5WFdyanlySzh5aisrQ2E2WjIwT3NIckVrVFEvdFo2TWI2UHhsSHQxSXlv?= =?utf-8?B?d3JVU3VibVkxT1ZUZWdOeUhSeUdWellOQ2ExczBnS1NpRUhMdFdVTTRjQlhI?= =?utf-8?B?YWo1NDRMN2w4NHZ0ZHBOZDZneWcwSERZVXBRRzZxYlhNUFVuU211VXQwcUcv?= =?utf-8?B?aWo4THJWUTVDbFZoWUZ2OHNkbWRnNDAwdWxVekc0T0lJcGFVN3lBOE50ZXQ5?= =?utf-8?B?dGpTMnMzWkRHaXQxZ3FzUW1iRTNIN2NaTUxQeWF2eEN0aVBlS2Z0SlJmVFph?= =?utf-8?B?dnUyTVg4dTB2OXZwM3lreDhVdWJlclNFN2NWemg5NjRabEJHeXNYeUlOcjhE?= =?utf-8?B?ZmxHMXBuWkxKODNhVTZxb3h4M1JzdE9OUHhHeXlKR2piMmVJZEJqN0tYM0d2?= =?utf-8?B?SkpvTjBLSXVseVJwbUk0MEFqd3hGT1RXb1JXM2pGMXZXa2p3UjVYZXRBeXh1?= =?utf-8?B?VlhNeDE0UzNwUWtFQUVNb01DVms1VS9VNHpyQUREUmpoODkyQWF5aDZ5NUow?= =?utf-8?B?alQxb014ZkFyKzFiMjdHTEdCNnZYUjJJenNXK2N6VDJnTkhnOXJWWGYzd2JK?= =?utf-8?B?cVNVN1ZUMDAwRlkybzc4OVpyVDZwZytqWFpOcVQvK2gxY3hVREFNdmNnNG0x?= =?utf-8?B?M2JsZUJLYTdDQnJlWmIrNEhRVnc1U25BWExtR1JsNjlYRlBhOTFBbHU4VE5W?= =?utf-8?B?OCszRmVKOGUvNk8wL2p3d1ZaTzBCZ2NXSytCK3Z2V1NmUWJqRC9DcTlLTW81?= =?utf-8?B?NXNVcVpEYXp6RG01d0JlcStITlZjR21KVC8reGJSUENwOVM4eEttT25UbDFI?= =?utf-8?B?QzZmamJBOHdHcDFwcnRicFhsbks0bjR0eUVwczFzM2pid21zcDh2blRPcDZU?= =?utf-8?B?Sm9PZU1YWHlUWEk4Z3hnNDBFWGdsT1M1L0hNOVpwTFBtTFlQTnFRQTVkZUlJ?= =?utf-8?B?T2ZRajV4YXEwanA0RUlPUEZwZy85K3NhbmtkN2tMdVlNc1JUSzZSOEcwTUlz?= =?utf-8?B?NHEyb0Zzb0l1Q1hNbWtONTJNRkVERDI2TnFnRlJMWm40U3lEM3FMMVJuYVFD?= =?utf-8?B?d3E0dzJxODQrd3ZhYVA5aFNHMUtsSDhBK2J1Q0dmZ2g1VTNmODBWbDZiTG9m?= =?utf-8?B?NkdSenhCb2hycW1wMWJYcm40NjFBbisraUNDNmdYYmxYc291SVdNVkJUNVRN?= =?utf-8?Q?SYgj3XGu7ZFxzc9oAL474V4KU?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: eba63a0c-a2b6-40fc-b54c-08ddc457b48f X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2025 10:58:32.9665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PQ7J2gQJ2mev/rbagTp74SH/iIfnrF3NgdOHHIK+29IBCHqJrWVmAmVL+M2dhPRE X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9798 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 16.07.25 12:46, Philipp Stanner wrote: > +Cc Greg, Sasha > > On Wed, 2025-07-16 at 12:40 +0200, Michel Dänzer wrote: >> On 16.07.25 11:57, Philipp Stanner wrote: >>> On Wed, 2025-07-16 at 09:43 +0000, cao, lin wrote: >>>> >>>> Hi Philipp, >>>> >>>> >>>> Thank you for the review. I found that this optimization was >>>> introduced 9 years ago in commit >>>> 777dbd458c89d4ca74a659f85ffb5bc817f29a35 ("drm/amdgpu: drop a >>>> dummy >>>> wakeup scheduler"). >>>> >>>> >>>> Given that the codebase has undergone significant changes over >>>> these >>>> 9 years. May I ask if I still need to include the Fixes: tag? >>> >>> Yes. It's a helpful marker to see where the problem comes from, and >>> it >>> adds redundancy helping the stable-kernel maintainers in figuring >>> out >>> to which kernels to backport it to. >>> >>> If stable can't apply a patch to a very old stable kernel because >>> the >>> code base changed too much, they'll ping us and we might provide a >>> dedicated fix. >>> >>> So like that: >>> >>> Cc: stable@vger.kernel.org # v4.6+ >>> Fixes: 777dbd458c89 ("drm/amdgpu: drop a dummy wakeup scheduler") >> >> FWIW, Fixes: alone is enough for getting backported to stable >> branches, Cc: stable is redundant with it. > > Both are used all the time together, though. And the official > documentation does not list dropping Cc: stable as a valid option in > this regard > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1 > > > As long as the official documentation demands it, I'm not willing to > drop it. If the docu were to be changed, that would be fine by me, too. As far as I understand "CC: stable" and "Fixes:" tags are to handle two distinct use cases. "CC: stable..." means please backport, eventually with a kernel version and/or necessary pre-requisites. "Fixes:" only backport if you have this patch in your tree as well. In other words it is a restriction when to backport something. Would be nice if somebody could clarify if my understanding here is accurate. Regards, Christian. > > > P. > > >> >> >