From: Sagi Grimberg <sagi@grimberg.me>
To: Keith Busch <kbusch@kernel.org>, Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: nvme-tcp poll queue crash
Date: Mon, 20 Mar 2023 22:01:12 +0200 [thread overview]
Message-ID: <ff4fd0e2-588c-4e41-a9ed-52e76ea8e7d6@grimberg.me> (raw)
In-Reply-To: <5f38f8fe-5180-04bc-6b77-a5b1e4960dda@grimberg.me>
>>>> nvme-tcp: kernel NULL pointer dereference, address: 0000000000000034
>>>
>>> Thanks, I couldn't remember this discussion.
>>
>> It just happened late last week, so no worries.
>>
>> I believe we can get rid of bio and bdev dependency, and I am working on
>> detangling how to get the cookie through without these.
>
> Keith,
>
> I think we shouldn't have an issue *today* because the only non fs
> I/O that can be polled is the fabrics connect, which has a payload
> and hence has a bio. The minimal change to fix the regression afaict
> is protecting against a polled request submission of a user command
> that doesn't have a payload (just fail it), which again, shouldn't
> happen afaict.
On top of the fix you already suggested of course...
prev parent reply other threads:[~2023-03-20 20:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 14:19 nvme-tcp poll queue crash Daniel Wagner
2023-03-20 14:36 ` Sagi Grimberg
2023-03-20 14:51 ` Daniel Wagner
2023-03-20 15:06 ` Keith Busch
2023-03-20 15:22 ` Daniel Wagner
2023-03-20 17:38 ` [PATCH v1 0/2] Test different queue counts Daniel Wagner
2023-03-20 17:38 ` [PATCH v1 1/2] nvme/rc: Parse optional arguments in _nvme_connect_subsys() Daniel Wagner
2023-03-21 5:16 ` Chaitanya Kulkarni
2023-03-21 7:20 ` Daniel Wagner
2023-03-22 5:17 ` Chaitanya Kulkarni
2023-03-20 17:38 ` [PATCH v1 2/2] nvme/047: Test different queue counts Daniel Wagner
2023-03-20 20:00 ` nvme-tcp poll queue crash Sagi Grimberg
2023-03-20 20:01 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4fd0e2-588c-4e41-a9ed-52e76ea8e7d6@grimberg.me \
--to=sagi@grimberg.me \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.