From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, andrew@lunn.ch
Cc: kai.heng.feng@canonical.com, hayeswang@realtek.com,
hkallweit1@gmail.com, romieu@fr.zoreil.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ryankao@realtek.com, jiri@resnulli.us
Subject: Re: [PATCH] r8169: Reinstate ALDPS and ASPM support
Date: Tue, 5 Jun 2018 09:47:22 -0700 [thread overview]
Message-ID: <ff5da1dc-09b4-90c3-6d8b-ef7dab5dc876@gmail.com> (raw)
In-Reply-To: <20180605.101532.899235999013307302.davem@davemloft.net>
On 06/05/2018 07:15 AM, David Miller wrote:
> From: Andrew Lunn <andrew@lunn.ch>
> Date: Tue, 5 Jun 2018 16:11:14 +0200
>
>> No module parameter please. Just turn it on by default. Assuming
>> testing shows works.
>
> Agreed.
devlink would be a good candidate to add such configuration attributes,
since you would be operating on the PCI function itself, thus allowing
this to be on a per-device instance basis as opposed to global, which is
what a module parameter is.
--
Florian
next prev parent reply other threads:[~2018-06-05 16:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 4:58 [PATCH] r8169: Reinstate ALDPS and ASPM support Kai-Heng Feng
2018-06-05 5:02 ` Kai Heng Feng
2018-06-05 6:34 ` Ryankao
2018-06-05 17:28 ` Bjorn Helgaas
2018-06-05 19:11 ` Bjorn Helgaas
2018-06-05 19:17 ` Heiner Kallweit
2018-06-05 19:27 ` Florian Fainelli
2018-06-05 19:41 ` Heiner Kallweit
2018-06-05 19:24 ` Heiner Kallweit
2018-06-06 6:58 ` Kai-Heng Feng
2018-06-06 13:25 ` Bjorn Helgaas
2018-06-05 14:11 ` Andrew Lunn
2018-06-05 14:15 ` David Miller
2018-06-05 16:47 ` Florian Fainelli [this message]
2018-06-06 6:47 ` Kai-Heng Feng
2018-06-06 12:34 ` Andrew Lunn
2018-06-07 4:15 ` Kai Heng Feng
2018-06-05 19:13 ` Heiner Kallweit
2018-06-06 6:12 ` Simon Horman
2018-06-06 7:03 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff5da1dc-09b4-90c3-6d8b-ef7dab5dc876@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=jiri@resnulli.us \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=ryankao@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.