All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Watt <JPEW.hacker@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] multiconfig: Adapt to bitbake switch 'multiconfig' -> 'mc'
Date: Fri, 7 Jun 2019 10:51:48 -0500	[thread overview]
Message-ID: <ff680a45-8b31-6167-d5b5-e1a242fc006d@gmail.com> (raw)
In-Reply-To: <20190607154805.15741-1-richard.purdie@linuxfoundation.org>

Is there a reason for this change other than aesthetics?

FWIW, we maintain some recipes across several versions of poky, so this 
rename is going to cause me some headaches

On 6/7/19 10:48 AM, Richard Purdie wrote:
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   .../recipes-test/multiconfig/multiconfig-image-packager_0.1.bb  | 2 +-
>   meta/lib/oe/sstatesig.py                                        | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-selftest/recipes-test/multiconfig/multiconfig-image-packager_0.1.bb b/meta-selftest/recipes-test/multiconfig/multiconfig-image-packager_0.1.bb
> index 3dbc0f5d155..a76a6bea1b8 100644
> --- a/meta-selftest/recipes-test/multiconfig/multiconfig-image-packager_0.1.bb
> +++ b/meta-selftest/recipes-test/multiconfig/multiconfig-image-packager_0.1.bb
> @@ -8,7 +8,7 @@ MCIMGTYPE_virtclass-mcextend-tiny = "cpio.gz"
>   
>   MC_DEPLOY_DIR_IMAGE = "${TOPDIR}/tmp-mc-${MCNAME}/deploy/images/${MCMACHINE}"
>   
> -do_install[mcdepends] += "multiconfig::${MCNAME}:core-image-minimal:do_image_complete multiconfig::${MCNAME}:virtual/kernel:do_deploy"
> +do_install[mcdepends] += "mc::${MCNAME}:core-image-minimal:do_image_complete mc::${MCNAME}:virtual/kernel:do_deploy"
>   
>   do_install () {
>       install -d ${D}/var/lib/machines/${MCNAME}
> diff --git a/meta/lib/oe/sstatesig.py b/meta/lib/oe/sstatesig.py
> index 417943db902..13af16e473c 100644
> --- a/meta/lib/oe/sstatesig.py
> +++ b/meta/lib/oe/sstatesig.py
> @@ -155,7 +155,7 @@ class SignatureGeneratorOEBasicHash(bb.siggen.SignatureGeneratorBasicHash):
>           else:
>               def get_mc(tid):
>                   tid = tid.rsplit('.', 1)[0]
> -                if tid.startswith('multiconfig:'):
> +                if tid.startswith('mc:'):
>                       elems = tid.split(':')
>                       return elems[1]
>               def recipename_from_dep(dep):


  reply	other threads:[~2019-06-07 15:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 15:48 [PATCH] multiconfig: Adapt to bitbake switch 'multiconfig' -> 'mc' Richard Purdie
2019-06-07 15:51 ` Joshua Watt [this message]
2019-06-07 16:23   ` richard.purdie
2019-06-07 16:30     ` Joshua Watt
2019-06-10 17:53       ` Alejandro Hernandez
2019-06-11  9:02         ` richard.purdie
2019-06-07 20:08   ` akuster808
2019-06-07 20:27     ` Joshua Watt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff680a45-8b31-6167-d5b5-e1a242fc006d@gmail.com \
    --to=jpew.hacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.