From: Akira Yokosawa <akiyks@gmail.com>
To: Ryszard Knop <ryszard.knop@intel.com>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Shuicheng Lin <shuicheng.lin@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH] scripts/kernel-doc: Fix kdoc for Python 3.9-3.11
Date: Sat, 1 Aug 2026 21:12:00 +0900 [thread overview]
Message-ID: <ff702136-839e-4d3e-957f-92573182df0e@gmail.com> (raw)
In-Reply-To: <20260731144508.912049-1-ryszard.knop@intel.com>
Hi,
On Fri, 31 Jul 2026 16:45:08 +0200, Ryszard Knop wrote:
> The syntax used by the excess description suggestion change works on
> Python 3.12+, while we need to support 3.9+.
>
> Signed-off-by: Ryszard Knop <ryszard.knop@intel.com>
Tested-by: Akira Yokosawa <akiyks@gmail.com>
And here are needed tags for helping Jon (supposed to go ahead of Sob):
Fixes: d7758384ccb4 ("scripts/kernel-doc: Suggest possible names for excess descriptions")
Reported-by: Akira Yokosawa <akiyks@gmail.com>
Closes: https://lore.kernel.org/22a9276d-c103-4306-a617-7f34abcd5c29@gmail.com/
> ---
> tools/lib/python/kdoc/kdoc_parser.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/lib/python/kdoc/kdoc_parser.py b/tools/lib/python/kdoc/kdoc_parser.py
> index 884f42584667..9cba20f827c4 100644
> --- a/tools/lib/python/kdoc/kdoc_parser.py
> +++ b/tools/lib/python/kdoc/kdoc_parser.py
> @@ -601,7 +601,8 @@ class KernelDoc:
> if not suggestions:
> return ""
>
> - return f"(did you mean one of: '{"', '".join(suggestions)}')"
> + joined_suggestions = "', '".join(suggestions)
> + return f"(did you mean one of: '{joined_suggestions}')"
>
> def check_sections(self, ln, decl_name, decl_type):
> """
Thanks, Akira
prev parent reply other threads:[~2026-08-01 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 14:45 [PATCH] scripts/kernel-doc: Fix kdoc for Python 3.9-3.11 Ryszard Knop
2026-07-31 16:45 ` Jonathan Corbet
2026-08-01 12:12 ` Akira Yokosawa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff702136-839e-4d3e-957f-92573182df0e@gmail.com \
--to=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=ryszard.knop@intel.com \
--cc=shuicheng.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.