From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF757C7618D for ; Thu, 6 Apr 2023 19:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sB0tHdT1YXoXce7RJSxpJPvdGmCjXEDTKzHRnSXQ9rs=; b=VNC5ntlrPucBxE cNNPWR2xE7JZxNNxtvM7d8TQomrKzb+vFLbYtHeo5clkmI1XSjipLrMYuVRMpQD5pbbt3I5qDMDmG plO0ddo/snmvGjfAcMSwRJE3MNBeVlPc+TSZosEsVvU47lfXywaQgfTDLnFVIztsD6uIuSawT78LC zxvN1ogXE/3QCi96N1WufNHMoZBWYt0miETeJZ/t0eQIgbGvw03wLkl5d+59JFr2X4CBtuUewXr4W qK6OiPssZwbxN65PhwnTVtqQ0CLzSunHlFmL5p9eORfV+RqQk7tl8Mv4Jw36iUDvK1IhPkRKeUKlN 6YWMr0KxqWaGRn/rjtng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkVkh-008ReX-38; Thu, 06 Apr 2023 19:58:35 +0000 Received: from mx2.securetransport.de ([2a03:4000:13:6c7::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkVkd-008Rd6-3C for linux-arm-kernel@lists.infradead.org; Thu, 06 Apr 2023 19:58:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1680811052; bh=hIHZKMCNlD1nj8tlj6y6ab9ucYMc5iHFk+XQ3oEEOmg=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=ixn+X+rixKEeyGUXMD1SrI1W5wdniFZH1OTqrhIZMbvlhyprtrm+gfou01oEdR/oe mckiG0/lJB2phvh8GuaKBrj8LZZlrHJrQx0jb8gvXd5hRogpVM5gvggRNdmRMY1deY X8mWJXnFVz5D10mAvHQuqHXtLv0nRyXzpmhZue8TY5S0F8G8vv+KzfT14jy7nTTrUY kzEh8TtQql/1A5CZCKaKo6hC3AIJHVSuOFLvmQhIly9HOLl9/eAKCATGSyaKDOJxRf xQsuiDcTKEDu++R4VC7YaOFj97bp0qfiHL273g4UAEHDFND/dNnOeCw2FLHwcN+Ztl k4CXVM79quwNw== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" CC: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Li Yang , Marek Vasut , Fabio Estevam , NXP Linux Team , kernel , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Thread-Topic: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Thread-Index: AQHZaJ93At1GnP2el0yoagNBg+3G/K8eWhSAgAAwTiD//+YUAIAAON0Q Date: Thu, 6 Apr 2023 19:57:22 +0000 Message-ID: References: <20230406154900.6423-1-cniedermaier@dh-electronics.com> <20230406154900.6423-3-cniedermaier@dh-electronics.com> <5478133e-7772-1db9-3473-1ec86fa2aae2@linaro.org> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230406_125832_363701_6A1A8B96 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] Sent: Thursday, April 6, 2023 8:00 PM > On 06/04/2023 19:54, Christoph Niedermaier wrote: > >>>> +++ b/arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts >>>> @@ -0,0 +1,361 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT >>>> +/* >>>> + * Copyright (C) 2023 DH electronics GmbH >>>> + * Copyright (C) 2023 Marantec electronics GmbH >>>> + * >>>> + * DHCOM iMX6ULL variant: >>>> + * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG >>>> + * DHCOR PCB number: 578-200 or newer >>>> + * maveo box PCB number: 525-200 or newer >>>> + */ >>>> + >>>> +/dts-v1/; >>>> + >>>> +#include "imx6ull-dhcor-som.dtsi" >>>> + >>>> +/ { >>>> + model = "DH electronics i.MX6ULL DHCOR on maveo box"; >>>> + compatible = "marantec,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som", >>>> + "fsl,imx6ull"; >>>> + >>>> + aliases { >>>> + /delete-property/ mmc0; /* Avoid double definitions */ >>> >>> I don't understand it. What is "double definition" of aliases? >> >> Otherwise I end up like this: >> mmc0 = &usdhc1; >> mmc1 = &usdhc2; >> mmc2 = &usdhc2; >> >> Is "Ensure unique allocation" a better comment here? >> >>> >>>> + /delete-property/ mmc1; >>>> + mmc2 = &usdhc2; /* eMMC should be mmc2 */ >>> >>> Why? How is this labeled on the board (physically or on schematics)? If >>> you answer here "for booting", then the answer is NAK. Don't add >>> software policies to Devicetree. >> >> The name in the schematics is "SD2". > > Answering also to above - then likely the aliases should be dropped from > SoM. I doubt that Som calls it SD1 and your board SD2... Maybe I don't quite get it, but the hardware starts counting at 1. The first interface is SD1 and it is used as WiFi. The second one is SD2 which is the eMMC. So with this aliases it should match SD2 to mmc2. Do you want me to delete the aliases in the include file "imx6ull-dhcor-som.dtsi" or what can I do? Thanks and regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F41C76196 for ; Thu, 6 Apr 2023 19:58:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbjDFT6r (ORCPT ); Thu, 6 Apr 2023 15:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjDFT6q (ORCPT ); Thu, 6 Apr 2023 15:58:46 -0400 Received: from mx2.securetransport.de (mx2.securetransport.de [IPv6:2a03:4000:13:6c7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 536D383D0; Thu, 6 Apr 2023 12:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1680811052; bh=hIHZKMCNlD1nj8tlj6y6ab9ucYMc5iHFk+XQ3oEEOmg=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=ixn+X+rixKEeyGUXMD1SrI1W5wdniFZH1OTqrhIZMbvlhyprtrm+gfou01oEdR/oe mckiG0/lJB2phvh8GuaKBrj8LZZlrHJrQx0jb8gvXd5hRogpVM5gvggRNdmRMY1deY X8mWJXnFVz5D10mAvHQuqHXtLv0nRyXzpmhZue8TY5S0F8G8vv+KzfT14jy7nTTrUY kzEh8TtQql/1A5CZCKaKo6hC3AIJHVSuOFLvmQhIly9HOLl9/eAKCATGSyaKDOJxRf xQsuiDcTKEDu++R4VC7YaOFj97bp0qfiHL273g4UAEHDFND/dNnOeCw2FLHwcN+Ztl k4CXVM79quwNw== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" CC: Rob Herring , Krzysztof Kozlowski , Shawn Guo , Li Yang , Marek Vasut , Fabio Estevam , NXP Linux Team , kernel , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Thread-Topic: [PATCH V2 3/3] ARM: dts: imx6ull-dhcor: Add Marantec maveo box Thread-Index: AQHZaJ93At1GnP2el0yoagNBg+3G/K8eWhSAgAAwTiD//+YUAIAAON0Q Date: Thu, 6 Apr 2023 19:57:22 +0000 Message-ID: References: <20230406154900.6423-1-cniedermaier@dh-electronics.com> <20230406154900.6423-3-cniedermaier@dh-electronics.com> <5478133e-7772-1db9-3473-1ec86fa2aae2@linaro.org> In-Reply-To: Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org RnJvbTogS3J6eXN6dG9mIEtvemxvd3NraSBbbWFpbHRvOmtyenlzenRvZi5rb3psb3dza2lAbGlu YXJvLm9yZ10NClNlbnQ6IFRodXJzZGF5LCBBcHJpbCA2LCAyMDIzIDg6MDAgUE0NCj4gT24gMDYv MDQvMjAyMyAxOTo1NCwgQ2hyaXN0b3BoIE5pZWRlcm1haWVyIHdyb3RlOg0KPiANCj4+Pj4gKysr IGIvYXJjaC9hcm0vYm9vdC9kdHMvaW14NnVsbC1kaGNvci1tYXZlby1ib3guZHRzDQo+Pj4+IEBA IC0wLDAgKzEsMzYxIEBADQo+Pj4+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIu MC1vci1sYXRlciBPUiBNSVQNCj4+Pj4gKy8qDQo+Pj4+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMjMg REggZWxlY3Ryb25pY3MgR21iSA0KPj4+PiArICogQ29weXJpZ2h0IChDKSAyMDIzIE1hcmFudGVj IGVsZWN0cm9uaWNzIEdtYkgNCj4+Pj4gKyAqDQo+Pj4+ICsgKiBESENPTSBpTVg2VUxMIHZhcmlh bnQ6DQo+Pj4+ICsgKiBESENSLWlNWDZVTEwtQzA4MC1SMDUxLVNQSS1XQlQtSS0wMUxHDQo+Pj4+ ICsgKiBESENPUiBQQ0IgbnVtYmVyOiA1NzgtMjAwIG9yIG5ld2VyDQo+Pj4+ICsgKiBtYXZlbyBi b3ggUENCIG51bWJlcjogNTI1LTIwMCBvciBuZXdlcg0KPj4+PiArICovDQo+Pj4+ICsNCj4+Pj4g Ky9kdHMtdjEvOw0KPj4+PiArDQo+Pj4+ICsjaW5jbHVkZSAiaW14NnVsbC1kaGNvci1zb20uZHRz aSINCj4+Pj4gKw0KPj4+PiArLyB7DQo+Pj4+ICsgICAgIG1vZGVsID0gIkRIIGVsZWN0cm9uaWNz IGkuTVg2VUxMIERIQ09SIG9uIG1hdmVvIGJveCI7DQo+Pj4+ICsgICAgIGNvbXBhdGlibGUgPSAi bWFyYW50ZWMsaW14NnVsbC1kaGNvci1tYXZlby1ib3giLCAiZGgsaW14NnVsbC1kaGNvci1zb20i LA0KPj4+PiArICAgICAgICAgICAgICAgICAgImZzbCxpbXg2dWxsIjsNCj4+Pj4gKw0KPj4+PiAr ICAgICBhbGlhc2VzIHsNCj4+Pj4gKyAgICAgICAgICAgICAvZGVsZXRlLXByb3BlcnR5LyBtbWMw OyAvKiBBdm9pZCBkb3VibGUgZGVmaW5pdGlvbnMgKi8NCj4+Pg0KPj4+IEkgZG9uJ3QgdW5kZXJz dGFuZCBpdC4gV2hhdCBpcyAiZG91YmxlIGRlZmluaXRpb24iIG9mIGFsaWFzZXM/DQo+Pg0KPj4g T3RoZXJ3aXNlIEkgZW5kIHVwIGxpa2UgdGhpczoNCj4+IG1tYzAgPSAmdXNkaGMxOw0KPj4gbW1j MSA9ICZ1c2RoYzI7DQo+PiBtbWMyID0gJnVzZGhjMjsNCj4+DQo+PiBJcyAiRW5zdXJlIHVuaXF1 ZSBhbGxvY2F0aW9uIiBhIGJldHRlciBjb21tZW50IGhlcmU/DQo+Pg0KPj4+DQo+Pj4+ICsgICAg ICAgICAgICAgL2RlbGV0ZS1wcm9wZXJ0eS8gbW1jMTsNCj4+Pj4gKyAgICAgICAgICAgICBtbWMy ID0gJnVzZGhjMjsgLyogZU1NQyBzaG91bGQgYmUgbW1jMiAqLw0KPj4+DQo+Pj4gV2h5PyBIb3cg aXMgdGhpcyBsYWJlbGVkIG9uIHRoZSBib2FyZCAocGh5c2ljYWxseSBvciBvbiBzY2hlbWF0aWNz KT8gSWYNCj4+PiB5b3UgYW5zd2VyIGhlcmUgImZvciBib290aW5nIiwgdGhlbiB0aGUgYW5zd2Vy IGlzIE5BSy4gRG9uJ3QgYWRkDQo+Pj4gc29mdHdhcmUgcG9saWNpZXMgdG8gRGV2aWNldHJlZS4N Cj4+DQo+PiBUaGUgbmFtZSBpbiB0aGUgc2NoZW1hdGljcyBpcyAiU0QyIi4NCj4gDQo+IEFuc3dl cmluZyBhbHNvIHRvIGFib3ZlIC0gdGhlbiBsaWtlbHkgdGhlIGFsaWFzZXMgc2hvdWxkIGJlIGRy b3BwZWQgZnJvbQ0KPiBTb00uIEkgZG91YnQgdGhhdCBTb20gY2FsbHMgaXQgU0QxIGFuZCB5b3Vy IGJvYXJkIFNEMi4uLg0KDQpNYXliZSBJIGRvbid0IHF1aXRlIGdldCBpdCwgYnV0IHRoZSBoYXJk d2FyZSBzdGFydHMgY291bnRpbmcgYXQgMS4gVGhlIGZpcnN0DQppbnRlcmZhY2UgaXMgU0QxIGFu ZCBpdCBpcyB1c2VkIGFzIFdpRmkuIFRoZSBzZWNvbmQgb25lIGlzIFNEMiB3aGljaCBpcyB0aGUN CmVNTUMuIFNvIHdpdGggdGhpcyBhbGlhc2VzIGl0IHNob3VsZCBtYXRjaCBTRDIgdG8gbW1jMi4N CkRvIHlvdSB3YW50IG1lIHRvIGRlbGV0ZSB0aGUgYWxpYXNlcyBpbiB0aGUgaW5jbHVkZSBmaWxl ICJpbXg2dWxsLWRoY29yLXNvbS5kdHNpIg0Kb3Igd2hhdCBjYW4gSSBkbz8NCg0KDQpUaGFua3Mg YW5kIHJlZ2FyZHMNCkNocmlzdG9waA0K