From: Matthieu Baerts <matttbe@kernel.org>
To: Mat Martineau <martineau@kernel.org>
Cc: MPTCP Linux <mptcp@lists.linux.dev>
Subject: Re: [PATCH mptcp-net] mptcp: pm: reset retrans_time when ADD_ADDR entry is reused
Date: Sat, 15 Aug 2026 19:29:22 +0200 [thread overview]
Message-ID: <ffb6d0ba-172b-4227-b13d-73b532928890@kernel.org> (raw)
In-Reply-To: <caa3dce5-940c-8068-8069-93bc3ac7896a@kernel.org>
Hi Mat,
On 14/08/2026 03:22, Mat Martineau wrote:
> On Wed, 5 Aug 2026, Matthieu Baerts (NGI0) wrote:
>
>> When an ADD_ADDR entry is reused, the timer is re-armed, because the
>> goal is to re-announce an ADD_ADDR, and eventually retransmit it if
>> needed.
>>
>> In this case, the retransmission counter should be reset as well, so the
>> re-announced address gets its retransmissions back instead of relying on
>> what was left before, and possibly not being able to retransmit it.
(...)
> Looks good to me, thanks for the fix.
Thank you for the review!
Now in our tree:
New patches for t/upstream-net and t/upstream:
- f9ff581a97d0: mptcp: pm: reset retrans_time when ADD_ADDR entry is reused
- Results: 745049d83503..79d7297194ac (export-net)
- Results: d536472a82d1..199ed983c1f7 (export)
Tests are now in progress:
- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/9bf507e411f4bc32904bdf34fdbe9e9406e9d025/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/ba6afbce3cb1ec026c104c44bfebe101bbd2ef35/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2026-08-15 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 13:20 [PATCH mptcp-net] mptcp: pm: reset retrans_time when ADD_ADDR entry is reused Matthieu Baerts (NGI0)
2026-08-05 15:12 ` MPTCP CI
2026-08-14 1:22 ` Mat Martineau
2026-08-15 17:29 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffb6d0ba-172b-4227-b13d-73b532928890@kernel.org \
--to=matttbe@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.