From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Mon, 12 Feb 2018 15:57:29 -0800 Subject: [PATCH] arm64: Make L1_CACHE_SHIFT configurable In-Reply-To: References: <1518479125-14428-1-git-send-email-f.fainelli@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/12/2018 03:52 PM, Timur Tabi wrote: > On 02/12/2018 05:45 PM, Florian Fainelli wrote: >> +config ARM64_L1_CACHE_SHIFT >> +??? int >> +??? default 7 if ARM64_L1_CACHE_SHIFT_7 >> +??? default 6 > > Shouldn't this be the other way around?? Everyone is used to 7 now, so > you're changing the default back to 6.? I would think that it should be > 7 by default, and platforms like Brahma-B53 should force it to 6. That is debatable, is there a good publicly available table of what the typical L1 cache line size is on ARMv8 platforms? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932873AbeBLX5m (ORCPT ); Mon, 12 Feb 2018 18:57:42 -0500 Received: from mail-qk0-f194.google.com ([209.85.220.194]:33971 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932712AbeBLX5l (ORCPT ); Mon, 12 Feb 2018 18:57:41 -0500 X-Google-Smtp-Source: AH8x2268eXi57dAEC6WuGGPPVVTQbXFksO4I1xVY8ugpUyakU5chqUNFgVAC7gCpBwSq6qYqc87Y2w== Subject: Re: [PATCH] arm64: Make L1_CACHE_SHIFT configurable To: Timur Tabi , linux-arm-kernel@lists.infradead.org Cc: tchalamarla@cavium.com, rrichter@cavium.com, opendmb@gmail.com, Catalin Marinas , Will Deacon , Mark Rutland , open list References: <1518479125-14428-1-git-send-email-f.fainelli@gmail.com> From: Florian Fainelli Message-ID: Date: Mon, 12 Feb 2018 15:57:29 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/12/2018 03:52 PM, Timur Tabi wrote: > On 02/12/2018 05:45 PM, Florian Fainelli wrote: >> +config ARM64_L1_CACHE_SHIFT >> +    int >> +    default 7 if ARM64_L1_CACHE_SHIFT_7 >> +    default 6 > > Shouldn't this be the other way around?  Everyone is used to 7 now, so > you're changing the default back to 6.  I would think that it should be > 7 by default, and platforms like Brahma-B53 should force it to 6. That is debatable, is there a good publicly available table of what the typical L1 cache line size is on ARMv8 platforms? -- Florian