From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [CI 1/6] drm/i915: Remove temporary allocation of dma addresses when rotating Date: Fri, 17 Feb 2017 16:28:13 +0000 Message-ID: References: <20170217151304.16665-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 700086E0B4 for ; Fri, 17 Feb 2017 16:28:16 +0000 (UTC) In-Reply-To: <20170217151304.16665-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE3LzAyLzIwMTcgMTU6MTIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUgb2JqZWN0IGFs cmVhZHkgc3RvcmVzIChjb21wdXRlZCBvbiB0aGUgZmx5KSB0aGUgaW5kZXggdG8gZG1hIGFkZHJl c3MKPiBzbyB1c2UgaXQgaW5zdGVhZCBvZiByZWFsbG9jYXRpbmcgYSBsYXJnZSB0ZW1wb3Jhcnkg YXJyYXkgZXZlcnkgdGltZSB3ZQo+IGJpbmQgYSByb3RhdGVkIGZyYW1lYnVmZmVyLgoKT24gdGhl IG90aGVyIGhhbmQgaG93IGJpZyBpcyB0aGUgcmFkaXggdHJlZSBmb3IgYSBsYXJnZSBmcmFtZWJ1 ZmZlcj8gSSAKcmVtZW1iZXIgdGhvc2Ugbm9kZXMgd2VyZSBxdWl0ZSBjaHVua3kgYW5kIHdpbGwg aGFuZyBhcm91bmQgZm9yIHRoZSAKbGlmZXRpbWUgb2YgdGhlIG9iamVjdC4gV2hpbGUgdGhlIGFi b3ZlIG1lbnRpb25lZCBsYXJnZSB0ZW1wb3JhcnkgYXJyYXkgCm5lZWRzIHRvIGJlIGFsbG9jYXRl ZCBvbmx5IGlmIHJvdGF0ZWQgVk1BcyBoYXZlIGJlZW4gZGlzY2FyZGVkIGR1ZSBHR1RUIApwcmVz c3VyZSwgbm8/CgpPbiB0aGUgb3RoZXIgb3RoZXIgaGFuZCBtYXliZSB0aGUgcmFkaXggdHJlZSB3 b24ndCBiZSBzbyBiaWcgaW4gdGhlIAp0eXBpY2FsIGNhc2UsIGR1ZSBzZyBlbnRyeSBjb2FsZXNj aW5nLCBidXQgaXQgd2lsbCBoYW5nIGFyb3VuZCBmb3IgbXVjaCAKbG9uZ2VyLgoKPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWF0 dGhldyBBdWxkIDxtYXR0aGV3LndpbGxpYW0uYXVsZEBnbWFpbC5jb20+Cj4gQ2M6IEpvb25hcyBM YWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogVHZydGtvIFVy c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmMgfCA3NyArKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCA1MiBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gaW5kZXggNDdhMzgyNzJmNTRj Li44NDhkYmI5MjZmZDEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fZ3R0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IEBA IC0zMDQzLDI3ICszMDQzLDMyIEBAIHZvaWQgaTkxNV9nZW1fcmVzdG9yZV9ndHRfbWFwcGluZ3Mo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB9Cj4KPiAgc3RhdGljIHN0cnVj dCBzY2F0dGVybGlzdCAqCj4gLXJvdGF0ZV9wYWdlcyhjb25zdCBkbWFfYWRkcl90ICppbiwgdW5z aWduZWQgaW50IG9mZnNldCwKPiAtCSAgICAgdW5zaWduZWQgaW50IHdpZHRoLCB1bnNpZ25lZCBp bnQgaGVpZ2h0LAo+IC0JICAgICB1bnNpZ25lZCBpbnQgc3RyaWRlLAo+ICtyb3RhdGVfcGFnZXMo c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiArCSAgICAgY29uc3Qgc3RydWN0IGlu dGVsX3JvdGF0aW9uX3BsYW5lX2luZm8gKnAsCj4gIAkgICAgIHN0cnVjdCBzZ190YWJsZSAqc3Qs IHN0cnVjdCBzY2F0dGVybGlzdCAqc2cpCj4gIHsKPiAgCXVuc2lnbmVkIGludCBjb2x1bW4sIHJv dzsKPiAtCXVuc2lnbmVkIGludCBzcmNfaWR4Owo+Cj4gLQlmb3IgKGNvbHVtbiA9IDA7IGNvbHVt biA8IHdpZHRoOyBjb2x1bW4rKykgewo+IC0JCXNyY19pZHggPSBzdHJpZGUgKiAoaGVpZ2h0IC0g MSkgKyBjb2x1bW47Cj4gLQkJZm9yIChyb3cgPSAwOyByb3cgPCBoZWlnaHQ7IHJvdysrKSB7Cj4g LQkJCXN0LT5uZW50cysrOwo+ICsJZm9yIChjb2x1bW4gPSAwOyBjb2x1bW4gPCBwLT53aWR0aDsg Y29sdW1uKyspIHsKPiArCQl1bnNpZ25lZCBsb25nIHNyY19pZHggPQo+ICsJCQlwLT5zdHJpZGUg KiAocC0+aGVpZ2h0IC0gMSkgKyBjb2x1bW4gKyBwLT5vZmZzZXQ7Cj4gKwkJZm9yIChyb3cgPSAw OyByb3cgPCBwLT5oZWlnaHQ7IHJvdysrKSB7Cj4gKwkJCXN0cnVjdCBzY2F0dGVybGlzdCAqc3Jj Owo+ICsJCQl1bnNpZ25lZCBpbnQgbjsKPiArCj4gKwkJCXNyYyA9IGk5MTVfZ2VtX29iamVjdF9n ZXRfc2cob2JqLCBzcmNfaWR4LCAmbik7Cj4gKwkJCXNyY19pZHggLT0gcC0+c3RyaWRlOwo+ICsK PiAgCQkJLyogV2UgZG9uJ3QgbmVlZCB0aGUgcGFnZXMsIGJ1dCBuZWVkIHRvIGluaXRpYWxpemUK PiAgCQkJICogdGhlIGVudHJpZXMgc28gdGhlIHNnIGxpc3QgY2FuIGJlIGhhcHBpbHkgdHJhdmVy c2VkLgo+ICAJCQkgKiBUaGUgb25seSB0aGluZyB3ZSBuZWVkIGFyZSBETUEgYWRkcmVzc2VzLgo+ ICAJCQkgKi8KPiAgCQkJc2dfc2V0X3BhZ2Uoc2csIE5VTEwsIFBBR0VfU0laRSwgMCk7Cj4gLQkJ CXNnX2RtYV9hZGRyZXNzKHNnKSA9IGluW29mZnNldCArIHNyY19pZHhdOwo+ICsJCQlzZ19kbWFf YWRkcmVzcyhzZykgPSBzZ19kbWFfYWRkcmVzcyhzcmMpICsgbipQQUdFX1NJWkU7Cj4gIAkJCXNn X2RtYV9sZW4oc2cpID0gUEFHRV9TSVpFOwo+IC0JCQlzZyA9IHNnX25leHQoc2cpOwo+IC0JCQlz cmNfaWR4IC09IHN0cmlkZTsKPiArCQkJc2cgPSBfX3NnX25leHQoc2cpOwo+ICsKPiArCQkJc3Qt Pm5lbnRzKys7Cj4gIAkJfQo+ICAJfQo+Cj4gQEAgLTMwNzQsNjIgKzMwNzksMzAgQEAgc3RhdGlj IG5vaW5saW5lIHN0cnVjdCBzZ190YWJsZSAqCj4gIGludGVsX3JvdGF0ZV9wYWdlcyhzdHJ1Y3Qg aW50ZWxfcm90YXRpb25faW5mbyAqcm90X2luZm8sCj4gIAkJICAgc3RydWN0IGRybV9pOTE1X2dl bV9vYmplY3QgKm9iaikKPiAgewo+IC0JY29uc3QgdW5zaWduZWQgbG9uZyBuX3BhZ2VzID0gb2Jq LT5iYXNlLnNpemUgLyBQQUdFX1NJWkU7Cj4gLQl1bnNpZ25lZCBpbnQgc2l6ZSA9IGludGVsX3Jv dGF0aW9uX2luZm9fc2l6ZShyb3RfaW5mbyk7Cj4gLQlzdHJ1Y3Qgc2d0X2l0ZXIgc2d0X2l0ZXI7 Cj4gLQlkbWFfYWRkcl90IGRtYV9hZGRyOwo+IC0JdW5zaWduZWQgbG9uZyBpOwo+IC0JZG1hX2Fk ZHJfdCAqcGFnZV9hZGRyX2xpc3Q7Cj4gLQlzdHJ1Y3Qgc2dfdGFibGUgKnN0Owo+ICsJY29uc3Qg dW5zaWduZWQgaW50IHNpemUgPSBpbnRlbF9yb3RhdGlvbl9pbmZvX3NpemUocm90X2luZm8pOwo+ ICAJc3RydWN0IHNjYXR0ZXJsaXN0ICpzZzsKPiArCXN0cnVjdCBzZ190YWJsZSAqc3Q7Cj4gKwl1 bnNpZ25lZCBsb25nIGk7Cj4gIAlpbnQgcmV0ID0gLUVOT01FTTsKPgo+IC0JLyogQWxsb2NhdGUg YSB0ZW1wb3JhcnkgbGlzdCBvZiBzb3VyY2UgcGFnZXMgZm9yIHJhbmRvbSBhY2Nlc3MuICovCj4g LQlwYWdlX2FkZHJfbGlzdCA9IGRybV9tYWxsb2NfZ2ZwKG5fcGFnZXMsCj4gLQkJCQkJc2l6ZW9m KGRtYV9hZGRyX3QpLAo+IC0JCQkJCUdGUF9URU1QT1JBUlkpOwo+IC0JaWYgKCFwYWdlX2FkZHJf bGlzdCkKPiAtCQlyZXR1cm4gRVJSX1BUUihyZXQpOwo+IC0KPiAtCS8qIEFsbG9jYXRlIHRhcmdl dCBTRyBsaXN0LiAqLwo+ICAJc3QgPSBrbWFsbG9jKHNpemVvZigqc3QpLCBHRlBfS0VSTkVMKTsK PiAgCWlmICghc3QpCj4gLQkJZ290byBlcnJfc3RfYWxsb2M7Cj4gKwkJZ290byBlcnI7Cj4KPiAg CXJldCA9IHNnX2FsbG9jX3RhYmxlKHN0LCBzaXplLCBHRlBfS0VSTkVMKTsKPiAgCWlmIChyZXQp Cj4gLQkJZ290byBlcnJfc2dfYWxsb2M7Cj4gLQo+IC0JLyogUG9wdWxhdGUgc291cmNlIHBhZ2Ug bGlzdCBmcm9tIHRoZSBvYmplY3QuICovCj4gLQlpID0gMDsKPiAtCWZvcl9lYWNoX3NndF9kbWEo ZG1hX2FkZHIsIHNndF9pdGVyLCBvYmotPm1tLnBhZ2VzKQo+IC0JCXBhZ2VfYWRkcl9saXN0W2kr K10gPSBkbWFfYWRkcjsKPiArCQlnb3RvIGVycjsKPgo+IC0JR0VNX0JVR19PTihpICE9IG5fcGFn ZXMpOwo+ICAJc3QtPm5lbnRzID0gMDsKPiAgCXNnID0gc3QtPnNnbDsKPiAtCj4gLQlmb3IgKGkg PSAwIDsgaSA8IEFSUkFZX1NJWkUocm90X2luZm8tPnBsYW5lKTsgaSsrKSB7Cj4gLQkJc2cgPSBy b3RhdGVfcGFnZXMocGFnZV9hZGRyX2xpc3QsIHJvdF9pbmZvLT5wbGFuZVtpXS5vZmZzZXQsCj4g LQkJCQkgIHJvdF9pbmZvLT5wbGFuZVtpXS53aWR0aCwgcm90X2luZm8tPnBsYW5lW2ldLmhlaWdo dCwKPiAtCQkJCSAgcm90X2luZm8tPnBsYW5lW2ldLnN0cmlkZSwgc3QsIHNnKTsKPiAtCX0KPiAt Cj4gLQlEUk1fREVCVUdfS01TKCJDcmVhdGVkIHJvdGF0ZWQgcGFnZSBtYXBwaW5nIGZvciBvYmpl Y3Qgc2l6ZSAlenUgKCV1eCV1IHRpbGVzLCAldSBwYWdlcylcbiIsCj4gLQkJICAgICAgb2JqLT5i YXNlLnNpemUsIHJvdF9pbmZvLT5wbGFuZVswXS53aWR0aCwgcm90X2luZm8tPnBsYW5lWzBdLmhl aWdodCwgc2l6ZSk7CgpIbSBnaXZlbiBob3cgY2hhdHR5IEtNUyBsb2cgbGV2ZWwgaXMgdGhpcyBv bmUgd2Fzbid0IHRoYXQgaGFybWZ1bCBidXQgCk9LLiBVc2UgdG8gc2F2ZSBtZSBsb29raW5nIGlu IGRlYnVnZnMvaTkxNV9nZW1fZnJhbWVidWZmZXIgYW5kIGV5ZWJhbGwgCnRoZSBWTUEgbGlzdC4g R3JhbnRlZCB0aGF0IGlzIG11Y2ggbW9yZSBtYW5hZ2VhYmxlIG5vdyBhZnRlciB5b3UgYWRkZWQg CnRoZSBodW1hbiByZWFkYWJsZSBvdXRwdXQgdGhlcmUuCgo+IC0KPiAtCWRybV9mcmVlX2xhcmdl KHBhZ2VfYWRkcl9saXN0KTsKPiArCWZvciAoaSA9IDAgOyBpIDwgQVJSQVlfU0laRShyb3RfaW5m by0+cGxhbmUpOyBpKyspCj4gKwkJc2cgPSByb3RhdGVfcGFnZXMob2JqLCAmcm90X2luZm8tPnBs YW5lW2ldLCBzdCwgc2cpOwo+ICsJR0VNX0JVR19PTihzdC0+bmVudHMgIT0gc2l6ZSk7Cj4KPiAg CXJldHVybiBzdDsKPgo+IC1lcnJfc2dfYWxsb2M6Cj4gK2VycjoKPiAgCWtmcmVlKHN0KTsKPiAt ZXJyX3N0X2FsbG9jOgo+IC0JZHJtX2ZyZWVfbGFyZ2UocGFnZV9hZGRyX2xpc3QpOwo+IC0KPiAt CURSTV9ERUJVR19LTVMoIkZhaWxlZCB0byBjcmVhdGUgcm90YXRlZCBtYXBwaW5nIGZvciBvYmpl Y3Qgc2l6ZSAlenUhICgldXgldSB0aWxlcywgJXUgcGFnZXMpXG4iLAo+IC0JCSAgICAgIG9iai0+ YmFzZS5zaXplLCByb3RfaW5mby0+cGxhbmVbMF0ud2lkdGgsIHJvdF9pbmZvLT5wbGFuZVswXS5o ZWlnaHQsIHNpemUpOwo+IC0KPiAgCXJldHVybiBFUlJfUFRSKHJldCk7Cj4gIH0KPgo+CgpDb2Rl IGxvb2tzIGZpbmUuIEJ1dCBJIHdvdWxkIGxpa2UgdG8gdGhpbmsgYWJvdXQgbnVtYmVycyBzb21l IG1vcmUuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=