From mboxrd@z Thu Jan 1 00:00:00 1970 From: vnkgutta@codeaurora.org Subject: Re: [PATCH v2 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs Date: Fri, 24 Aug 2018 11:38:10 -0700 Message-ID: References: <1534550915-18230-1-git-send-email-vnkgutta@codeaurora.org> <1534550915-18230-4-git-send-email-vnkgutta@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Evan Green Cc: robh@kernel.org, mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, tsoni@codeaurora.org, ckadabi@codeaurora.org, rishabhb@codeaurora.org, bp@alien8.de List-Id: linux-arm-msm@vger.kernel.org On 2018-08-23 16:07, Evan Green wrote: > On Thu, Aug 23, 2018 at 4:04 PM Evan Green > wrote: >> >> On Fri, Aug 17, 2018 at 5:08 PM Venkata Narendra Kumar Gutta >> wrote: >> > >> > From: Channagoud Kadabi > > Also checkpatch.pl complains a bit about this patch: > > WARNING: Non-standard signature: Co-developed-by: > #14: > Co-developed-by: Venkata Narendra Kumar Gutta > This needs to be there as the original author is Channagoud Kadabi and I'm the one who is modifying and upstreaming this driver. It was suggested to have this kind of signature from the earlier patchset comments. Can we do anything about this? > > WARNING: please write a paragraph that describes the > config symbol fully > #63: FILE: drivers/edac/Kconfig:460: > +config EDAC_QCOM This is also, I will check if I can get rid of this by writing more in the description. I don't really understand why do we need a paragraph here. > > WARNING: DT compatible string "qcom,llcc-edac" appears > un-documented -- check ./Documentation/devicetree/bindings/ > #536: FILE: drivers/edac/qcom_edac.c:430: > + { .compatible = "qcom,llcc-edac" }, This file is not added in the dt-bindings as there are no properties (like reg-names or interrupts) for this driver and anyway initialized from llcc driver. Do we still need to have the Documentation in place? > > total: 0 errors, 3 warnings, 533 lines checked > > -Evan From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,3/4] drivers: edac: Add EDAC driver support for QCOM SoCs From: Venkata Narendra Kumar Gutta Message-Id: Date: Fri, 24 Aug 2018 11:38:10 -0700 To: Evan Green Cc: robh@kernel.org, mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, tsoni@codeaurora.org, ckadabi@codeaurora.org, rishabhb@codeaurora.org, bp@alien8.de List-ID: T24gMjAxOC0wOC0yMyAxNjowNywgRXZhbiBHcmVlbiB3cm90ZToKPiBPbiBUaHUsIEF1ZyAyMywg MjAxOCBhdCA0OjA0IFBNIEV2YW4gR3JlZW4gPGV2Z3JlZW5AY2hyb21pdW0ub3JnPiAKPiB3cm90 ZToKPj4gCj4+IE9uIEZyaSwgQXVnIDE3LCAyMDE4IGF0IDU6MDggUE0gVmVua2F0YSBOYXJlbmRy YSBLdW1hciBHdXR0YQo+PiA8dm5rZ3V0dGFAY29kZWF1cm9yYS5vcmc+IHdyb3RlOgo+PiA+Cj4+ ID4gRnJvbTogQ2hhbm5hZ291ZCBLYWRhYmkgPGNrYWRhYmlAY29kZWF1cm9yYS5vcmc+Cj4gCj4g QWxzbyBjaGVja3BhdGNoLnBsIGNvbXBsYWlucyBhIGJpdCBhYm91dCB0aGlzIHBhdGNoOgo+IAo+ ICAgICAgICAgICAgIFdBUk5JTkc6IE5vbi1zdGFuZGFyZCBzaWduYXR1cmU6IENvLWRldmVsb3Bl ZC1ieToKPiAgICAgICAgICAgICAjMTQ6Cj4gICAgICAgICAgICAgQ28tZGV2ZWxvcGVkLWJ5OiBW ZW5rYXRhIE5hcmVuZHJhIEt1bWFyIEd1dHRhCj4gPHZua2d1dHRhQGNvZGVhdXJvcmEub3JnPgoK VGhpcyBuZWVkcyB0byBiZSB0aGVyZSBhcyB0aGUgb3JpZ2luYWwgYXV0aG9yIGlzIENoYW5uYWdv dWQgS2FkYWJpCmFuZCBJJ20gdGhlIG9uZSB3aG8gaXMgbW9kaWZ5aW5nIGFuZCB1cHN0cmVhbWlu ZyB0aGlzIGRyaXZlci4KSXQgd2FzIHN1Z2dlc3RlZCB0byBoYXZlIHRoaXMga2luZCBvZiBzaWdu YXR1cmUgZnJvbSB0aGUgZWFybGllciAKcGF0Y2hzZXQgY29tbWVudHMuCgpDYW4gd2UgZG8gYW55 dGhpbmcgYWJvdXQgdGhpcz8KCj4gCj4gICAgICAgICAgICAgV0FSTklORzogcGxlYXNlIHdyaXRl IGEgcGFyYWdyYXBoIHRoYXQgZGVzY3JpYmVzIHRoZQo+IGNvbmZpZyBzeW1ib2wgZnVsbHkKPiAg ICAgICAgICAgICAjNjM6IEZJTEU6IGRyaXZlcnMvZWRhYy9LY29uZmlnOjQ2MDoKPiAgICAgICAg ICAgICArY29uZmlnIEVEQUNfUUNPTQoKVGhpcyBpcyBhbHNvLCBJIHdpbGwgY2hlY2sgaWYgSSBj YW4gZ2V0IHJpZCBvZiB0aGlzIGJ5IHdyaXRpbmcgbW9yZSBpbiAKdGhlIGRlc2NyaXB0aW9uLgpJ IGRvbid0IHJlYWxseSB1bmRlcnN0YW5kIHdoeSBkbyB3ZSBuZWVkIGEgcGFyYWdyYXBoIGhlcmUu Cgo+IAo+ICAgICAgICAgICAgIFdBUk5JTkc6IERUIGNvbXBhdGlibGUgc3RyaW5nICJxY29tLGxs Y2MtZWRhYyIgYXBwZWFycwo+IHVuLWRvY3VtZW50ZWQgLS0gY2hlY2sgLi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvCj4gICAgICAgICAgICAgIzUzNjogRklMRTogZHJpdmVycy9l ZGFjL3Fjb21fZWRhYy5jOjQzMDoKPiAgICAgICAgICAgICArIHsgLmNvbXBhdGlibGUgPSAicWNv bSxsbGNjLWVkYWMiIH0sCgpUaGlzIGZpbGUgaXMgbm90IGFkZGVkIGluIHRoZSBkdC1iaW5kaW5n cyBhcyB0aGVyZSBhcmUgbm8gcHJvcGVydGllcyAKKGxpa2UgcmVnLW5hbWVzIG9yIGludGVycnVw dHMpIGZvciB0aGlzIGRyaXZlcgphbmQgYW55d2F5IGluaXRpYWxpemVkIGZyb20gbGxjYyBkcml2 ZXIuCgpEbyB3ZSBzdGlsbCBuZWVkIHRvIGhhdmUgdGhlIERvY3VtZW50YXRpb24gaW4gcGxhY2U/ Cgo+IAo+ICAgICAgICAgICAgIHRvdGFsOiAwIGVycm9ycywgMyB3YXJuaW5ncywgNTMzIGxpbmVz IGNoZWNrZWQKPiAKPiAtRXZhbgo=