From: "Bills, Jason M" <jason.m.bills@linux.intel.com>
To: yocto@lists.yoctoproject.org
Subject: EXTRA_IMAGECMD:squashfs-xz support
Date: Thu, 29 Sep 2022 15:26:25 -0600 [thread overview]
Message-ID: <ffeb477c-ba3a-8a81-d720-d73119fc91ce@linux.intel.com> (raw)
Hello,
I work on OpenBMC and am having an issue with EXTRA_IMAGECMD:squashfs-xz.
There was a recent change pulled into OpenBMC in image_types.bbclass. In
the old file, IMAGE_CMD:squashfs-xz was defined directly:
IMAGE_CMD:squashfs-xz = "mksquashfs ${IMAGE_ROOTFS}
${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.squashfs-xz
${EXTRA_IMAGECMD} -noappend -comp xz"
In the new file, it is defined using a method:
oe_mksquashfs () {
local comp=$1
local suffix=$2
# Use the bitbake reproducible timestamp instead of the hardcoded
squashfs one
export SOURCE_DATE_EPOCH=$(stat -c '%Y' ${IMAGE_ROOTFS})
mksquashfs ${IMAGE_ROOTFS}
${IMGDEPLOYDIR}/${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.squashfs${comp:+-}${suffix:-$comp}
${EXTRA_IMAGECMD} -noappend ${comp:+-comp }$comp
}
IMAGE_CMD:squashfs-xz = "oe_mksquashfs xz"
In my build we append to EXTRA_IMAGECMD:squashfs-xz to add parameters to
the mksquashfs commmand like this:
EXTRA_IMAGECMD:squashfs-xz:append = "-processors ${BB_NUMBER_THREADS} -b
262144 -Xdict-size 100% -Xbcj arm"
With the old file, the EXTRA_IMAGECMD:squashfs-xz parameters are added
to the mksquashfs command. But with the new file, they don't get added
anymore. I wonder if the method loses the squashfs-xz context so the
empty EXTRA_IMAGECMD is used instead of EXTRA_IMAGECMD:squashfs-xz.
Should my EXTRA_IMAGECMD:squashfs-xz:append still work, or is there a
different way to add parameters to the IMAGE_CMD:squashfs-xz command
with the new approach?
Thanks!
-Jason
next reply other threads:[~2022-09-29 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 21:26 Bills, Jason M [this message]
2022-10-18 22:48 ` EXTRA_IMAGECMD:squashfs-xz support Bills, Jason M
2022-10-27 15:53 ` [yocto] " Quentin Schulz
2022-11-01 22:02 ` Bills, Jason M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffeb477c-ba3a-8a81-d720-d73119fc91ce@linux.intel.com \
--to=jason.m.bills@linux.intel.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.