All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Chen Pei <cp0613@linux.alibaba.com>, djbw@kernel.org
Cc: alison.schofield@intel.com, dave@stgolabs.net, guoren@kernel.org,
	icheng@nvidia.com, ira.weiny@intel.com, jic23@kernel.org,
	linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
	vishal.l.verma@intel.com
Subject: Re: [PATCH] cxl/acpi: Defer probe when ACPI0016 PCI root bridge is not ready
Date: Thu, 21 May 2026 10:13:45 -0700	[thread overview]
Message-ID: <ffec8ee4-8e93-4e72-96ac-1e6bdaa18d2e@intel.com> (raw)
In-Reply-To: <20260519015509.4699-1-cp0613@linux.alibaba.com>



On 5/18/26 6:55 PM, Chen Pei wrote:
> On Fri, 15 May 2026 12:24:50 -0700, Dan Williams wrote:
> 
>> If the platform is defined to defer PCI root scans then this dependency
>> must be declared. Specifically firmware needs to tell Linux about the
>> dependency given it does not order PCI enumeration before ACPI0017
>> enumeration by default. Something like: 
>>
>>   Device (CXLM) { // ACPI0017
>>       Name (_HID, "ACPI0017")
>>       Name (_DEP, Package () {
>>           \_SB.CXL0, // ACPI0016 host bridge
>>           \_SB.CXL1,
>>       })
>>   }
>>
>> ...in the firmware, and then:
>>
>> acpi_dev_clear_dependencies()
>>
>> ...for each acpi_pci_root_add().
>>
>> Then ACPI0017 will naturally await all of the ACPI0016 devices that the
>> firmware knows about.
> 
> Hi Dan,
> 
> Thanks for the guidance. The _DEP approach is clearly the right way
> to handle this - it's the proper ACPI standard mechanism for declaring
> device dependencies and avoids the permanent defer risk that Dave and
> others raised with the EPROBE_DEFER approach.
> 
> I plan to abandon this patch and implement the _DEP solution instead.
> Let me confirm my understanding of the two changes needed:
> 
> 1. Firmware (QEMU DSDT): Add a _DEP package to the ACPI0017 device
>    that references all ACPI0016 CXL host bridge devices in the system.
> 
> 2. Kernel (drivers/acpi/pci_root.c): Add acpi_dev_clear_dependencies()
>    at the end of acpi_pci_root_add() so that once an ACPI0016 device
>    is bound, its consumers (ACPI0017) are notified and can proceed
>    with probing.

Please submit a patch upstream for this. Thanks!

> 
> Is my understanding correct? Any other changes or considerations
> I might be missing?
> 
> Thanks,
> Pei


  reply	other threads:[~2026-05-21 17:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  2:32 [PATCH] cxl/acpi: Defer probe when ACPI0016 PCI root bridge is not ready Chen Pei
2026-05-14  7:31 ` Richard Cheng
2026-05-15 13:46   ` Chen Pei
2026-05-15 19:24     ` Dan Williams (nvidia)
2026-05-19  1:55       ` Chen Pei
2026-05-21 17:13         ` Dave Jiang [this message]
2026-05-14 17:10 ` Dave Jiang
2026-05-15 13:53   ` Chen Pei
2026-05-14 17:19 ` Alison Schofield
2026-05-15 13:56   ` Chen Pei
2026-05-15 15:38 ` Dave Jiang
2026-05-19  1:50   ` Chen Pei
  -- strict thread matches above, loose matches on Subject: below --
2026-05-26  3:12 [PATCH 1/2] ACPI: PCI: Clear _DEP dependencies after PCI root bridge attach sashiko-bot
2026-05-26  9:26 ` [PATCH] cxl/acpi: Defer probe when ACPI0016 PCI root bridge is not ready Chen Pei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffec8ee4-8e93-4e72-96ac-1e6bdaa18d2e@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=cp0613@linux.alibaba.com \
    --cc=dave@stgolabs.net \
    --cc=djbw@kernel.org \
    --cc=guoren@kernel.org \
    --cc=icheng@nvidia.com \
    --cc=ira.weiny@intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.