From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Ijxys-0004LD-G5
	for mharc-grub-devel@gnu.org; Mon, 22 Oct 2007 10:10:10 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ijxyr-0004KF-Fu
	for grub-devel@gnu.org; Mon, 22 Oct 2007 10:10:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ijxyq-0004JQ-S8
	for grub-devel@gnu.org; Mon, 22 Oct 2007 10:10:09 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ijxyq-0004JD-Nk
	for grub-devel@gnu.org; Mon, 22 Oct 2007 10:10:08 -0400
Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gcbgd-grub-devel@m.gmane.org>)
	id 1Ijxyo-0006Jg-Ta
	for grub-devel@gnu.org; Mon, 22 Oct 2007 10:10:07 -0400
Received: from root by ciao.gmane.org with local (Exim 4.43)
	id 1Ijxyk-0008Qc-Gi
	for grub-devel@gnu.org; Mon, 22 Oct 2007 14:10:02 +0000
Received: from adsl-69-234-196-162.dsl.irvnca.pacbell.net ([69.234.196.162])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <grub-devel@gnu.org>; Mon, 22 Oct 2007 14:10:02 +0000
Received: from wa1ter by adsl-69-234-196-162.dsl.irvnca.pacbell.net with local
	(Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <grub-devel@gnu.org>; Mon, 22 Oct 2007 14:10:02 +0000
X-Injected-Via-Gmane: http://gmane.org/
To: grub-devel@gnu.org
From: walt <wa1ter@myrealbox.com>
Date: Mon, 22 Oct 2007 06:31:22 -0700
Organization: none
Message-ID: <ffi8lg$f3t$1@ger.gmane.org>
References: <471B84B5.2030702@t-online.de> <20071021191932.GA3239@thorin>
	<471BA984.5020305@t-online.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Complaints-To: usenet@ger.gmane.org
X-Gmane-NNTP-Posting-Host: adsl-69-234-196-162.dsl.irvnca.pacbell.net
User-Agent: Thunderbird 3.0a1pre (X11/2007102206)
In-Reply-To: <471BA984.5020305@t-online.de>
Sender: news <news@ger.gmane.org>
X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4)
Subject: Re: [PATCH] startup.S does not find includes
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Oct 2007 14:10:09 -0000

Christian Franke wrote:
> Robert Millan wrote:
>> On Sun, Oct 21, 2007 at 06:56:21PM +0200, Christian Franke wrote:
>>> Hi,
>>>
>>> some recent checkin appearently introduces the following regression:
>>>
>>> Compilation fails if configure'd outside of $(srcdir).
>>> #include "kern/i386/realmode.S" and "kern/i386/loader.S" fail in 
>>> startup.S.
>>
>> Uhm I just noticed that previously existing #includes have relative 
>> paths,
>> e.g.:
>>
>> #include "lzo1x.S"
>>
>> Perhaps I should have done the same instead of adding new include dirs.
>>
>> Thoughts?
>>
> 
> For kern/i386/pc/startup.S:
> 
> #include "../realmode.S" // include pc-independent i386 realmode code
> 
> Should work without any -I option.

I considered that, but wouldn't it break compilation when building
in-tree, ie without an obj directory?