From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Organov Subject: Minor inconsistency: "git tag" requires space after -m. Date: Sat, 27 Oct 2007 15:55:01 +0400 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sat Oct 27 14:16:42 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ilkan-0004p6-Ny for gcvg-git-2@gmane.org; Sat, 27 Oct 2007 14:16:42 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752282AbXJ0MPI (ORCPT ); Sat, 27 Oct 2007 08:15:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752303AbXJ0MPI (ORCPT ); Sat, 27 Oct 2007 08:15:08 -0400 Received: from main.gmane.org ([80.91.229.2]:58787 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbXJ0MPG (ORCPT ); Sat, 27 Oct 2007 08:15:06 -0400 Received: from root by ciao.gmane.org with local (Exim 4.43) id 1IlkZC-0002U2-RX for git@vger.kernel.org; Sat, 27 Oct 2007 12:15:02 +0000 Received: from 87.236.81.130 ([87.236.81.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Oct 2007 12:15:02 +0000 Received: from osv by 87.236.81.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Oct 2007 12:15:02 +0000 X-Injected-Via-Gmane: http://gmane.org/ X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 87.236.81.130 User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Hello, It seems options parsing is somewhat broken in git-tag: $ git tag -a -m"Annotated tag" annotated-tag usage: git-tag [-n []] -l [] | [-a | -s | -u ] [-f | -d | -v] [-m | -F ] [] $ git tag -a -m "Annotated tag" annotated-tag $ git --version git version 1.5.3.4 This is inconsistent with, say, "git commit", that groks -m"Message" (without space after -m) just fine. -- Sergei. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: Minor inconsistency: "git tag" requires space after -m. Date: Sat, 27 Oct 2007 13:48:44 +0100 (BST) Message-ID: References: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: git@vger.kernel.org To: Sergei Organov X-From: git-owner@vger.kernel.org Sat Oct 27 14:49:33 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ill6a-0004Gh-AR for gcvg-git-2@gmane.org; Sat, 27 Oct 2007 14:49:32 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbXJ0MtV (ORCPT ); Sat, 27 Oct 2007 08:49:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752727AbXJ0MtU (ORCPT ); Sat, 27 Oct 2007 08:49:20 -0400 Received: from mail.gmx.net ([213.165.64.20]:50560 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752715AbXJ0MtU (ORCPT ); Sat, 27 Oct 2007 08:49:20 -0400 Received: (qmail invoked by alias); 27 Oct 2007 12:49:18 -0000 Received: from wbgn013.biozentrum.uni-wuerzburg.de (EHLO openvpn-client) [132.187.25.13] by mail.gmx.net (mp031) with SMTP; 27 Oct 2007 14:49:18 +0200 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1+JSKsxhRCJGIdr6TwipmhkdJPrteScLm8duLsFND 5/1qb7d/J3LrAO X-X-Sender: gene099@racer.site In-Reply-To: X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Hi, On Sat, 27 Oct 2007, Sergei Organov wrote: > It seems options parsing is somewhat broken in git-tag: > > $ git tag -a -m"Annotated tag" annotated-tag > usage: git-tag [-n []] -l [] | [-a | -s | -u ] [-f | -d | -v] [-m | -F ] [] > $ git tag -a -m "Annotated tag" annotated-tag > $ git --version > git version 1.5.3.4 > > This is inconsistent with, say, "git commit", that groks -m"Message" > (without space after -m) just fine. As it happens, we are in the middle of adding our own option parser which probably solves the issue. Can you please retest when we have that, and use it in builtin-tag? Thanks, Dscho From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Organov Subject: Re: Minor inconsistency: "git tag" requires space after -m. Date: Sat, 27 Oct 2007 17:14:03 +0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sat Oct 27 15:14:37 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IllUn-0002MQ-QO for gcvg-git-2@gmane.org; Sat, 27 Oct 2007 15:14:34 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753183AbXJ0NOV (ORCPT ); Sat, 27 Oct 2007 09:14:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753082AbXJ0NOV (ORCPT ); Sat, 27 Oct 2007 09:14:21 -0400 Received: from main.gmane.org ([80.91.229.2]:50050 "EHLO ciao.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752957AbXJ0NOU (ORCPT ); Sat, 27 Oct 2007 09:14:20 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IllUV-0004Fy-63 for git@vger.kernel.org; Sat, 27 Oct 2007 13:14:15 +0000 Received: from 87.236.81.130 ([87.236.81.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Oct 2007 13:14:15 +0000 Received: from osv by 87.236.81.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Oct 2007 13:14:15 +0000 X-Injected-Via-Gmane: http://gmane.org/ X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 87.236.81.130 User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Johannes Schindelin writes: > Hi, > > On Sat, 27 Oct 2007, Sergei Organov wrote: > >> It seems options parsing is somewhat broken in git-tag: >> >> $ git tag -a -m"Annotated tag" annotated-tag >> usage: git-tag [-n []] -l [] | [-a | -s | -u ] [-f | -d | -v] [-m | -F ] [] >> $ git tag -a -m "Annotated tag" annotated-tag >> $ git --version >> git version 1.5.3.4 >> >> This is inconsistent with, say, "git commit", that groks -m"Message" >> (without space after -m) just fine. > > As it happens, we are in the middle of adding our own option parser which > probably solves the issue. Can you please retest when we have that, and > use it in builtin-tag? I'm 100% sure there will be no inconsistencies once you unify options parsing among the tools, but I won't refrain from re-testing this anyway. -- Sergei.