From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty
Date: Mon, 05 Nov 2007 13:58:50 +0100 [thread overview]
Message-ID: <fgn429$gs9$1@ger.gmane.org> (raw)
In-Reply-To: 20071105124920.17726.qmail@746e9cce42b49f.315fe32.mid.smarden.org
[Cc: Gerrit Pape <pape@smarden.org>, git@vger.kernel.org]
Gerrit Pape wrote:
> + char *sub[] = { "cur", "new" };
[...]
> + for (i = 0; i < 2; ++i) {
Wouldn't it be better to use sizeof(sub)/sizeof(sub[0]) or it's macro
equivalent ARRAY_SIZE(sub) instead of hardcoding 2 to avoid errors?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2007-11-05 12:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 14:15 [PATCH] git-mailsplit: with maildirs try to process new/ if cur/ is empty Gerrit Pape
2007-10-26 16:01 ` Fernando J. Pereda
2007-11-05 12:49 ` Gerrit Pape
2007-11-05 12:58 ` Jakub Narebski [this message]
2007-11-05 21:26 ` Jeff King
2007-11-05 22:52 ` Alex Riesen
2007-11-06 1:41 ` Michael Cohen
2007-11-06 7:28 ` Alex Riesen
2007-11-06 7:51 ` Jeff King
2007-11-06 11:01 ` Johannes Schindelin
2007-11-06 15:47 ` Jeff King
2007-11-06 15:51 ` Johannes Schindelin
2007-11-06 16:35 ` Karl Hasselström
2007-11-06 16:58 ` Johannes Schindelin
2007-11-06 21:50 ` Alex Riesen
2007-11-06 8:54 ` [PATCH amend] git-mailsplit: with maildirs not only process cur/, but also new/ Gerrit Pape
2007-11-08 2:09 ` Junio C Hamano
2007-11-08 2:31 ` Jeff King
2007-11-08 7:24 ` Alex Riesen
2007-11-08 7:31 ` Fernando J. Pereda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='fgn429$gs9$1@ger.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.