From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] diffcore: Allow users to decide what funcname to use
Date: Tue, 13 Nov 2007 11:03:07 +0100 [thread overview]
Message-ID: <fhbsor$ebf$1@ger.gmane.org> (raw)
In-Reply-To: 47396B4C.6070406@op5.se
Andreas Ericsson wrote:
> Git can be smarter than that, and imo it should. This
> patch lets the diffcore grok a new configuration variable,
> "diff.funcnames", which can be set to "new", "old", or a
> boolean value, which will cause it to be "old" (for 'true')
> and 'none' (for 'false').
Wouldn't it be better to use existing 'diff driver' infrastructure
for this? See "Defining a custom hunk-header" section in
gitattributes(5).
On the other hand... no.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2007-11-13 10:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 9:44 git diff woes Andreas Ericsson
2007-11-12 10:01 ` Johannes Schindelin
2007-11-12 10:35 ` Andreas Ericsson
2007-11-12 10:50 ` Johannes Schindelin
2007-11-12 11:19 ` Andreas Ericsson
2007-11-12 21:30 ` Junio C Hamano
2007-11-13 0:03 ` Andreas Ericsson
2007-11-13 0:59 ` Johannes Schindelin
2007-11-13 2:53 ` Miles Bader
2007-11-13 7:40 ` Andreas Ericsson
2007-11-13 9:15 ` [PATCH] diffcore: Allow users to decide what funcname to use Andreas Ericsson
2007-11-13 10:03 ` Jakub Narebski [this message]
2007-11-13 10:07 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='fhbsor$ebf$1@ger.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.