All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ondřej Lysoněk" <olysonek@redhat.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [PATCH] sensors-detect: Move Winbond WPCD377I to the non-hwmon table
Date: Wed, 13 May 2020 10:08:57 +0000	[thread overview]
Message-ID: <flseerouoxy.fsf@redhat.com> (raw)
In-Reply-To: <20200512162308.5efc21d7@endymion>

Jean Delvare <jdelvare@suse.de> writes:

> Move the detection entry for the Winbond WPCD377I to the
> @non_hwmon_chip_ids table, where it belongs. This saves one line, and
> more importantly prevents "not-a-sensor" from being accidentally
> added to the list of kernel drivers.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> ---
>  prog/detect/sensors-detect |    9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> --- lm-sensors.orig/prog/detect/sensors-detect	2020-05-12 11:08:57.101496194 +0200
> +++ lm-sensors/prog/detect/sensors-detect	2020-05-12 16:18:49.375617471 +0200
> @@ -719,11 +719,6 @@
>  		i2c_addrs => [0x2c..0x2e],
>  		i2c_detect => sub { emc6w201_detect(@_); },
>  	}, {
> -		name => "Winbond WPCD377I",
> -		driver => "not-a-sensor",
> -		i2c_addrs => [0x2c..0x2e],
> -		i2c_detect => sub { lm85_detect(@_, 7); },
> -	}, {
>  		name => "Analog Devices ADT7462",
>  		driver => "adt7462",
>  		i2c_addrs => [0x5c, 0x58],
> @@ -1684,6 +1679,10 @@
>  		i2c_addrs => [0x2c..0x2f],
>  		i2c_detect => sub { w83791sd_detect(@_); },
>  	}, {
> +		name => "Winbond WPCD377I",
> +		i2c_addrs => [0x2c..0x2e],
> +		i2c_detect => sub { lm85_detect(@_, 7); },
> +	}, {
>  		name => "Fintek F75111R/RG/N (GPIO)",
>  		i2c_addrs => [0x37, 0x4e],
>  		i2c_detect => sub { fintek_detect(@_, 1); },
>
>
> -- 
> Jean Delvare
> SUSE L3 Support

Applied. Thanks!

Ondřej Lysoněk

      reply	other threads:[~2020-05-13 10:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 14:23 [PATCH] sensors-detect: Move Winbond WPCD377I to the non-hwmon table Jean Delvare
2020-05-13 10:08 ` Ondřej Lysoněk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=flseerouoxy.fsf@redhat.com \
    --to=olysonek@redhat.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.