From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JMADN-0003a0-Ve for mharc-grub-devel@gnu.org; Mon, 04 Feb 2008 17:55:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JMADN-0003ZB-5g for grub-devel@gnu.org; Mon, 04 Feb 2008 17:55:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JMADK-0003XJ-Iu for grub-devel@gnu.org; Mon, 04 Feb 2008 17:55:00 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JMADK-0003X9-7b for grub-devel@gnu.org; Mon, 04 Feb 2008 17:54:58 -0500 Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JMADJ-0002Me-Tb for grub-devel@gnu.org; Mon, 04 Feb 2008 17:54:58 -0500 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JMADH-0004gk-OY for grub-devel@gnu.org; Mon, 04 Feb 2008 22:54:55 +0000 Received: from adsl-69-234-179-108.dsl.irvnca.pacbell.net ([69.234.179.108]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 Feb 2008 22:54:55 +0000 Received: from wa1ter by adsl-69-234-179-108.dsl.irvnca.pacbell.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 04 Feb 2008 22:54:55 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: grub-devel@gnu.org From: walt Date: Mon, 04 Feb 2008 14:55:34 -0800 Organization: none Message-ID: References: <1202074413.560.7.camel@k9.localnet> <874pco90mm.fsf@xs4all.nl> <1202156471.582.11.camel@k9.localnet> <20080204222712.GA28299@thorin> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: adsl-69-234-179-108.dsl.irvnca.pacbell.net User-Agent: Thunderbird 3.0a1pre (X11/2008020404) In-Reply-To: <20080204222712.GA28299@thorin> Sender: news X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] to make grub2 compile on NetBSD X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 22:55:01 -0000 Robert Millan wrote: >>> walt writes: >>> >>>> NetBSD's gcc wants libgcc and libc to define __enable_execute_stack, >>>> but this is useless for a free-standing executable like grub. Define >>>> a dummy function in lieu of libgcc to supply __enable_execute_stack. >> Second try: >> >> Make NetBSD's gcc happy. >> >> * kern/mm.c: New dummy symbol __enable_execute_stack. >> (include/grub/mm.h): Likewise. > > This ChangeLog entry seems wrong. I'll write it up for you, as it's easier to > explain with an example: > > Make NetBSD's gcc happy. > > * include/grub/mm.h > [__NetBSD__] (__enable_execute_stack): New function prototype. > * kern/mm.c > [__NetBSD__] (__enable_execute_stack): New function. Okay, thanks. Does the [__NetBSD__] token denote an #ifdef? How would I indicate a patch for, say, Net/Free/Dragonfly BSD's at the same time? Oh, and should you mention that the new function does nothing? Marco: I didn't add the header for the changelog because I don't know who (if anyone) is going to commit it.