From: Milton Miller <miltonm@bga.com>
To: <netdev@vger.kernel.org>
Cc: linux-kernel@vger.org, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] tcp: correct kcalloc usage
Date: Thu, 10 Jul 2008 16:25:33 -0500 (CDT) [thread overview]
Message-ID: <for-27-patch8-2@bga.com> (raw)
In-Reply-To: <for-27-patch8-1@bga.com>
kcalloc is supposed to be called with the count as its first argument and
the element size as the second.
Signed-off-by: Milton Miller <miltonm@bga.com>
---
Both arguments are size_t so does not affect correctness. This
callsite is during module_init and therefore not performance critical.
Another patch will optimize the case when the count is variable but
the size is fixed.
diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
index 5ff0ce6..7ddc30f 100644
--- a/net/ipv4/tcp_probe.c
+++ b/net/ipv4/tcp_probe.c
@@ -224,7 +224,7 @@ static __init int tcpprobe_init(void)
if (bufsize < 0)
return -EINVAL;
- tcp_probe.log = kcalloc(sizeof(struct tcp_log), bufsize, GFP_KERNEL);
+ tcp_probe.log = kcalloc(bufsize, sizeof(struct tcp_log), GFP_KERNEL);
if (!tcp_probe.log)
goto err0;
next parent reply other threads:[~2008-07-10 21:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <for-27-patch8-1@bga.com>
2008-07-10 21:25 ` Milton Miller [this message]
2008-07-10 23:51 ` [PATCH] tcp: correct kcalloc usage David Miller
2008-07-10 21:28 ` [PATCH] alsa: " Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=for-27-patch8-2@bga.com \
--to=miltonm@bga.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.