From: Jan Blunck <jblunck@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 3/5] fuse: fix race in llseek
Date: Mon, 28 Apr 2008 08:34:06 +0000 (UTC) [thread overview]
Message-ID: <fv425u$n77$1@ger.gmane.org> (raw)
In-Reply-To: 20080425175657.912755144@szeredi.hu
On Fri, 25 Apr 2008 19:55:23 +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Fuse doesn't use i_mutex to protect setting i_size, and so
> generic_file_llseek() can be racy: it doesn't use i_size_read().
>
> So do a fuse specific llseek method, which does use i_size_read().
>
Is there any specific reason why we don't use i_size_read() in
generic_file_llseek()? If no, why don't you fix it instead?
Regards,
Jan
--
Jan Blunck <jblunck@suse.de>
next prev parent reply other threads:[~2008-04-28 8:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 17:55 [patch 0/5] fuse updates Miklos Szeredi
2008-04-25 17:55 ` [patch 1/5] fuse: fix max i/o size calculation Miklos Szeredi
2008-04-25 17:55 ` [patch 2/5] fuse: fix node ID type Miklos Szeredi
2008-04-25 17:55 ` [patch 3/5] fuse: fix race in llseek Miklos Szeredi
2008-04-28 2:26 ` Andrew Morton
2008-04-28 7:51 ` Miklos Szeredi
2008-04-28 8:34 ` Jan Blunck [this message]
2008-04-28 15:12 ` Miklos Szeredi
2008-04-25 17:55 ` [patch 4/5] fuse: fix truncation on short read Miklos Szeredi
2008-04-25 17:55 ` [patch 5/5] fuse: fix sparse warnings Miklos Szeredi
2008-04-28 2:20 ` [patch 0/5] fuse updates Andrew Morton
2008-04-28 7:46 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='fv425u$n77$1@ger.gmane.org' \
--to=jblunck@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.