From: "consul" <void@aleksoft.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Re: [4476] musicpal: Improve button handling (JanKiszka).
Date: Wed, 21 May 2008 09:45:16 -0700 [thread overview]
Message-ID: <g11jiu$gpm$1@ger.gmane.org> (raw)
In-Reply-To: 200805211507.05887.paul@codesourcery.com
"Paul Brook" <paul@codesourcery.com> wrote in message
news:200805211507.05887.paul@codesourcery.com...
>> Surely this should be in osdep.h as a conditional definition of sleep.
>
> The real bug is that we're using sleep() in the first place :-)
>
IMHO committed code should at least compile on all supported platforms. Even
a temporary fix is better than no fix at all. Using the sleep is certainly
not the best solution and Jan already proposed another patch without it, see
[RFC][PATCH 2/2] MusicPal: Add specific -hold-buttonoption, without the
sleep function, but as of today, the latest qemu svn (4511) does not compile
on Windows, and that's a real bug.
Alex.
prev parent reply other threads:[~2008-05-21 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-17 18:18 [Qemu-devel] [4476] musicpal: Improve button handling (Jan Kiszka) Andrzej Zaborowski
2008-05-20 16:55 ` [Qemu-devel] " consul
2008-05-21 13:17 ` Ian Jackson
2008-05-21 14:07 ` Paul Brook
2008-05-21 16:45 ` consul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='g11jiu$gpm$1@ger.gmane.org' \
--to=void@aleksoft.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.