From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: qemu-devel@nongnu.org, "Philippe Mathieu-Daudé " <philmd@linaro.org>
Cc: "Bin Meng" <bmeng.cn@gmail.com>,
"Cé dric Le Goater" <clg@kaod.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
qemu-block@nongnu.org,
"Daniel P . Berrangé " <berrange@redhat.com>,
"Luc Michel" <luc.michel@amd.com>,
"Philippe Mathieu-Daudé " <philmd@linaro.org>
Subject: Re: [PATCH v45 1/3] hw/sd/sdcard: Remove leftover comment about removed 'spi' Property
Date: Wed, 03 Jul 2024 15:03:57 +0300 [thread overview]
Message-ID: <g1quy.grldmsci80ps@linaro.org> (raw)
In-Reply-To: <20240703085907.66775-2-philmd@linaro.org>
On Wed, 03 Jul 2024 11:59, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>Commit c3287c0f70 ("hw/sd: Introduce a "sd-card" SPI variant
>model") removed the 'spi' property. Remove the comment left
>over.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>---
> hw/sd/sd.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/hw/sd/sd.c b/hw/sd/sd.c
>index b158402704..53767beaf8 100644
>--- a/hw/sd/sd.c
>+++ b/hw/sd/sd.c
>@@ -2473,10 +2473,6 @@ static Property sd_properties[] = {
> DEFINE_PROP_UINT8("spec_version", SDState,
> spec_version, SD_PHY_SPECv2_00_VERS),
> DEFINE_PROP_DRIVE("drive", SDState, blk),
>- /* We do not model the chip select pin, so allow the board to select
>- * whether card should be in SSI or MMC/SD mode. It is also up to the
>- * board to ensure that ssi transfers only occur when the chip select
>- * is asserted. */
> DEFINE_PROP_END_OF_LIST()
> };
>
>--
>2.41.0
>
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
next prev parent reply other threads:[~2024-07-03 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 8:59 [PATCH v45 0/3] hw/sd/sdcard: Cleanups before adding eMMC support Philippe Mathieu-Daudé
2024-07-03 8:59 ` [PATCH v45 1/3] hw/sd/sdcard: Remove leftover comment about removed 'spi' Property Philippe Mathieu-Daudé
2024-07-03 12:03 ` Manos Pitsidianakis [this message]
2024-07-03 8:59 ` [PATCH v45 2/3] hw/sd/sdcard: Use spec v3.01 by default Philippe Mathieu-Daudé
2024-07-03 8:59 ` [PATCH v45 3/3] hw/sd/sdcard: Do not store vendor data on block drive (CMD56) Philippe Mathieu-Daudé
2024-07-03 12:24 ` Manos Pitsidianakis
2024-07-03 13:17 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g1quy.grldmsci80ps@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=berrange@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=clg@kaod.org \
--cc=eduardo@habkost.net \
--cc=luc.michel@amd.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.