From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.scrye.com (scrye.com [75.148.32.185]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.scrye.com", Issuer "mail.scrye.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 282AE2C00ED for ; Sun, 18 Aug 2013 03:17:53 +1000 (EST) To: Bhushan Bharat-R65777 Subject: Re: MPC8315 reboot failure, lockdep splat possibly related? From: Anthony Foiani References: <6A3DF150A5B70D4F9B66A25E3F7C888D07114F7C@039-SN2MPN1-013.039d.mgd.msft.net> Date: Sat, 17 Aug 2013 11:17:49 -0600 In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D07114F7C@039-SN2MPN1-013.039d.mgd.msft.net> (Bhushan Bharat-R's message of "Sat\, 17 Aug 2013 04\:58\:34 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linuxppc-dev@lists.ozlabs.org" Reply-To: Anthony Foiani List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Bharat, greetings -- Bhushan Bharat-R65777 writes: > You should get rid of this by changing spin_lock/unlock() in > fsl_sata_set_irq_coalescing() to spin_lock_irqsave/restore() I'll do that -- thanks! Looks like linux-next still has plain spin_lock, not the irqsave variant. Is this something that needs to be pushed to mainline and/or stable? If it should go upstream, is this something that Freescale can do, or should I try to put together a patch? (I'd like to avoid having to do it myself, because I'm carrying out-of-tree patches that I'd have to port to linux-next before it'd be accepted there, I fear.) Either way, I'll definitely report if it fixes the splat on my 3.9.7 system. Thanks again! Best regards, Anthony Foiani