From: Sitsofe Wheeler <sitsofe@yahoo.com>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix rate control initialisation
Date: Mon, 02 Jun 2008 18:50:20 +0100 [thread overview]
Message-ID: <g21c9v$vdl$1@ger.gmane.org> (raw)
In-Reply-To: 1212392284.4148.7.camel@johannes.berg
Johannes Berg wrote:
> In commit 2e92e6f2c50b4baf85cca968f0e6f1b5c0df7d39 ("mac80211: use rate
> index in TX control") I forgot to initialise a few new variables to -1
> which means that the rate control algorithm is never triggered and 0 is
> used as the only rate index, effectively fixing the transmit bitrate at
> the lowest supported.
>
> This patch adds the missing initialisation.
This is far better (the rate sets itself to 24Mb/s or 36 Mb/s rather than
being fixed on 54 Mb/s). However when using iwl3945 the rate could not be
forced using iwconfig wlan0 rate 54M fixed and it took a little . The rate
it chooses also seems to bounce about a bit - simply telling networkmanager
to reconnect results in a different speed (although it's hard to tell how
good the connection is while this is happening).
--
Sitsofe | http://sucs.org/~sits/
next prev parent reply other threads:[~2008-06-02 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-01 16:22 [BISECTED][NEXT] Wifi downloads capped at 105Kbytes/s Sitsofe Wheeler
2008-06-01 16:22 ` Sitsofe Wheeler
2008-06-02 7:34 ` Johannes Berg
2008-06-02 7:38 ` [PATCH] mac80211: fix rate control initialisation Johannes Berg
2008-06-02 17:50 ` Sitsofe Wheeler [this message]
2008-06-03 8:24 ` Filippo Zangheri
2008-06-02 12:04 ` [BISECTED][NEXT] Wifi downloads capped at 105Kbytes/s Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='g21c9v$vdl$1@ger.gmane.org' \
--to=sitsofe@yahoo.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.