From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [80.91.229.2] (helo=ciao.gmane.org) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1K7DF7-0003GR-9k for openembedded-devel@openembedded.org; Fri, 13 Jun 2008 19:39:21 +0200 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1K7DEq-0005Ae-UJ for openembedded-devel@openembedded.org; Fri, 13 Jun 2008 17:39:00 +0000 Received: from s55917625.adsl.wanadoo.nl ([85.145.118.37]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Jun 2008 17:39:00 +0000 Received: from k.kooi by s55917625.adsl.wanadoo.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 13 Jun 2008 17:39:00 +0000 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@openembedded.org From: Koen Kooi Date: Fri, 13 Jun 2008 19:38:50 +0200 Message-ID: References: <1213345201.13942.3.camel@dax.rpnet.com> <74d0deb30806130306tf5ca604t7238ab26d715e03@mail.gmail.com> <74d0deb30806130925u7ec0c1e4sfdf2144e703f2b9a@mail.gmail.com> Mime-Version: 1.0 X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: s55917625.adsl.wanadoo.nl User-Agent: Thunderbird 3.0a2pre (Macintosh/2008060303) In-Reply-To: <74d0deb30806130925u7ec0c1e4sfdf2144e703f2b9a@mail.gmail.com> Sender: news Subject: Re: Switching SCM to git and commit/review policy X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.10 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2008 17:39:29 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit pHilipp Zabel wrote: >>> Personally, I'd like to see every patch to OE being sent to and >>> reviewed on the mailing list. >> I'd like to see that every commit has at least 2 SOBs, I care less on how >> they get there. Having the review out in the open should be the end goal, >> though. > > From Documentation/SubmittingPatches: > "The Signed-off-by: tag indicates that the signer was involved in the > development of the patch, or that he/she was in the patch's delivery path." > > In the kernel Signed-off-by is primarily used to mark the way a patch > took into the kernel. If we do this, maybe we should use the same > nomenclature and have Acked-by for statements of approval. (And > eventually Tested-by/Reviewed-by, too?) That is probably a good idea. regards, Koen