From: Helge Deller <deller@gmx.de>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath5k: use positive logic for HP laptop LEDs
Date: Mon, 21 Jul 2008 23:42:58 +0200 [thread overview]
Message-ID: <g62vt2$akl$1@ger.gmane.org> (raw)
In-Reply-To: 20080715170716.GA5785@hash.localnet
Bob, I think your patch below somehow got truncated and you wanted to send
this patch ?
http://marc.info/?l=linux-wireless&m=121557127930799&w=2
Bob Copeland wrote:
> Helge Deller reports that HP laptops (NC4010 and NC6000) use active-
> high signals to turn on the LEDs. Previous code used active-low for
> all devices.
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
> Other ath5k devs, any issues with this patch? Thread here for
> reference:
>
> http://marc.info/?l=linux-wireless&m=121555862316630&w=2
>
> drivers/net/wireless/ath5k/base.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath5k/base.c
> b/drivers/net/wireless/ath5k/base.c index 217d506..3394b35 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -2550,8 +2550,6 @@ ath5k_init_leds(struct ath5k_softc *sc)
> struct pci_dev *pdev = sc->pdev;
> char name[ATH5K_LED_MAX_NAME_LEN + 1];
>
> - sc->led_on = 0; /* active low */
next prev parent reply other threads:[~2008-07-21 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 17:07 [PATCH] ath5k: use positive logic for HP laptop LEDs Bob Copeland
2008-07-21 21:42 ` Helge Deller [this message]
2008-07-21 21:58 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='g62vt2$akl$1@ger.gmane.org' \
--to=deller@gmx.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.