All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: PATCH: make h2200-bootloader load & depend on mtdblock
Date: Thu, 24 Jul 2008 09:19:46 +0200	[thread overview]
Message-ID: <g69aeh$5cu$1@ger.gmane.org> (raw)
In-Reply-To: <200807240048.20980.bluelightning@bluelightning.org>

Paul Eggleton wrote:
> Hi there,
>
> The attached patch fixes bug 4451 by making h2200-bootloader depend on
> kernel-module-mtdblock and load the mtdblock module before attempting to use
> it.
>
> http://bugs.openembedded.net/show_bug.cgi?id=4451
>
> Does this look OK?

No

+RDEPENDS = kernel-module-mtdblock

Never ever rdepend on a kernelmodules, since it might be built in to the 
kernel in the future (like it was in the past), only use

RRECOMMENDS_${PN} = "kernel-module-foo"

regards,

Koen




  parent reply	other threads:[~2008-07-24  7:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 23:48 PATCH: make h2200-bootloader load & depend on mtdblock Paul Eggleton
2008-07-24  1:06 ` Rolf Leggewie
2008-07-24  7:19 ` Koen Kooi [this message]
2008-07-24  8:08   ` Paul Eggleton
2008-07-24  9:01     ` Koen Kooi
2008-07-24  9:08     ` Richard Purdie
2008-07-24 13:04       ` Udo van den Heuvel
2008-07-24 13:23         ` Richard Purdie
2008-07-24 13:43           ` Udo van den Heuvel
2008-07-24 19:50       ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='g69aeh$5cu$1@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.