All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dbaryshkov@gmail.com>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/5] Separate common pxa2xx-ac97 code
Date: Mon, 8 Sep 2008 09:42:50 +0000 (UTC)	[thread overview]
Message-ID: <ga2s2q$sge$3@ger.gmane.org> (raw)
In-Reply-To: 1220866410.17091.81.camel@odin

Liam Girdwood wrote:

> On Mon, 2008-09-08 at 13:06 +0400, Dmitry Baryshkov wrote:
>> ASoC and non-ASoC drivers for ACLINK on PXA share lot's of common code.
>> Move all common code into separate file.
>> 
>> +#include "pxa2xx-ac97-lib.c"
>>  
>>  
> Any reason for not linking with pxa2xx-ac97-lib.o ?
> 

>> +#include "../../arm/pxa2xx-ac97-lib.c"
> 
> 
> ditto
> 
>>  static void pxa2xx_ac97_warm_reset(struct snd_ac97 *ac97) {
> 
> Liam


That is the interim change. In the next patch the file is fully separated
into distinct module. I can squash those patches if you'd prefer.


-- 
With best wishes
Dmitry

  reply	other threads:[~2008-09-08  9:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08  8:53 [GIT PULL] unify two pxa sound drivers Dmitry Baryshkov
2008-09-08  9:05 ` Liam Girdwood
2008-09-08  9:06 ` [PATCH 1/5] Permit simultaneous compilation of both PXA AC97 drivers Dmitry Baryshkov
2008-09-08  9:06   ` [PATCH 2/5] Separate common pxa2xx-ac97 code Dmitry Baryshkov
2008-09-08  9:06     ` [PATCH 3/5] Make pxa-ac97-lib separate module Dmitry Baryshkov
2008-09-08  9:06       ` [PATCH 4/5] pxa2xx-lib: support building for several pxa's Dmitry Baryshkov
2008-09-08  9:06         ` [PATCH 5/5] Separate common pxa2xx-pcm code Dmitry Baryshkov
2008-09-08 10:07           ` Eric Miao
2008-09-08 10:13             ` Dmitry
2008-09-08 10:33           ` Mark Brown
2008-09-08 10:17         ` [PATCH 4/5] pxa2xx-lib: support building for several pxa's Mark Brown
2008-09-08  9:33     ` [PATCH 2/5] Separate common pxa2xx-ac97 code Liam Girdwood
2008-09-08  9:42       ` Dmitry Baryshkov [this message]
2008-09-08  9:51         ` Liam Girdwood
2008-09-08  9:30   ` [PATCH 1/5] Permit simultaneous compilation of both PXA AC97 drivers Mark Brown
2008-09-08 10:19     ` Dmitry Baryshkov
2008-09-08 10:35       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='ga2s2q$sge$3@ger.gmane.org' \
    --to=dbaryshkov@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.