All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: liboil softfloat fix questions
Date: Thu, 25 Sep 2008 09:31:43 +0200	[thread overview]
Message-ID: <gbfeov$m8g$1@ger.gmane.org> (raw)

Hi,

I noticed liboil got patched:

+if test x"${ENABLE_SOFTFLOAT}" = "xyes"; then
+      VFP_CFLAGS="$VFP_CFLAGS -mfloat-abi=softfp"
+else
+      VFP_CFLAGS="$VFP_CFLAGS -mfpu=vfp"

That looks a bit wrong to me, since for EABI you'd want 
'-mfloat-abi=softfp -mfpu=vfp' to make it use the VFP coprocessor using 
softfloat calling conventions[1] and plain '-mfloat-abi=softfp' to do 
softfloat, and with OABI you don't want to pass '-mfloat-abi=softfp'
To make it even more complicated, on armv7a[2] you want to pass 
-mfpu=neon -mfloat-abi=softfp. If you look at the output of gcc -S 
you'll see that EABI won't use an FPU unless you pass in 
-mfloat-abi=softfp *and* -mfpu=<FPU>.

AFAICT OE passes all the needed magic already in TARGET_CCFLAGS, so it 
seems that this entire construct can be removed.

Robert, could you beat the cacao people with a cluebat so they get their 
stuff right?

regards,

Koen

[1] There are more permutations, but let's focus on the one OE is 
currently using
[2] On cortex-a8 the VFP isn't pipelined, so double precision math is 
twice as slow compared to ARM11 cores, the NEON unit is pipelined, but 
can only do single-precision. So don't be surprised if your new omap3 
nokia tablet performs FP math slower than your n810.




             reply	other threads:[~2008-09-25  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25  7:31 Koen Kooi [this message]
2008-09-25  8:06 ` liboil softfloat fix questions Khem Raj
2008-09-25  9:07   ` Koen Kooi
2008-09-25 10:33 ` Henning Heinold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gbfeov$m8g$1@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.