From: Dmitry Baryshkov <dbaryshkov@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 3/8] lcd: allow lcd device to handle mode change events
Date: Wed, 8 Oct 2008 14:07:51 +0000 (UTC) [thread overview]
Message-ID: <gciern$sc1$1@ger.gmane.org> (raw)
In-Reply-To: f17812d70808290026y39163cccy2d4b1fa3b30c8625@mail.gmail.com
Eric Miao wrote:
> Some LCD panels are capable of different resolutions, and is allowed to
> change at run-time, so to make "struct lcd_device" to be able to handle
> mode change events here.
>
> Signed-off-by: Eric Miao <eric.miao@marvell.com>
This patch broke a bit all existing fb drivers. At least you'll get a nice
segfault on modechange, if any lcd driver w/o set_mode is registered.
Please add a check for ld->ops->set_mode being non-NULL.
--
With best wishes
Dmitry
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
prev parent reply other threads:[~2008-10-08 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 7:26 [PATCH 3/8] lcd: allow lcd device to handle mode change events Eric Miao
2008-08-30 21:36 ` Dmitry Baryshkov
2008-08-31 7:20 ` Krzysztof Helt
2008-09-01 1:56 ` Eric Miao
2008-09-05 22:41 ` Andrew Morton
2008-10-08 14:07 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gciern$sc1$1@ger.gmane.org' \
--to=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.